From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 0B6753858D38 for ; Fri, 23 Sep 2022 17:24:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0B6753858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 38D92113E; Fri, 23 Sep 2022 10:24:36 -0700 (PDT) Received: from localhost (e121540-lin.manchester.arm.com [10.32.98.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2CAC73F5A1; Fri, 23 Sep 2022 10:24:29 -0700 (PDT) From: Richard Sandiford To: =?utf-8?Q?Torbj=C3=B6rn?= SVENSSON via Gcc-patches Mail-Followup-To: =?utf-8?Q?Torbj=C3=B6rn?= SVENSSON via Gcc-patches , =?utf-8?Q?Torbj=C3=B6rn?= SVENSSON , richard.sandiford@arm.com Cc: =?utf-8?Q?Torbj=C3=B6rn?= SVENSSON Subject: Re: [PATCH v2] testsuite: Skip intrinsics test if arm References: <20220920131337.843046-1-torbjorn.svensson@foss.st.com> Date: Fri, 23 Sep 2022 18:24:27 +0100 In-Reply-To: <20220920131337.843046-1-torbjorn.svensson@foss.st.com> (=?utf-8?Q?=22Torbj=C3=B6rn?= SVENSSON via Gcc-patches"'s message of "Tue, 20 Sep 2022 15:13:37 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-47.1 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Torbj=C3=B6rn SVENSSON via Gcc-patches writes: > In the test cases, it's clearly written that intrinsics is not > implemented on arm*. A simple xfail does not help since there are > link error and that would cause an UNRESOLVED testcase rather than > XFAIL. > By changing to dg-skip-if, the entire test case is omitted. > > gcc/testsuite/ChangeLog: > > * gcc.target/aarch64/advsimd-intrinsics/vld1x2.c: Replace > dg-xfail-if with gd-skip-if. Typo: s/gd/dg/ OK with that change, thanks. Richard > * gcc.target/aarch64/advsimd-intrinsics/vld1x3.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vld1x4.c: Likewise. > > Co-Authored-By: Yvan ROUX > Signed-off-by: Torbj=C3=B6rn SVENSSON > --- > gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c | 2 +- > gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c | 2 +- > gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c= b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c > index 92a139bc523..f933102be47 100644 > --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c > +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c > @@ -1,6 +1,6 @@ > /* We haven't implemented these intrinsics for arm yet. */ > -/* { dg-xfail-if "" { arm*-*-* } } */ > /* { dg-do run } */ > +/* { dg-skip-if "unsupported" { arm*-*-* } } */ > /* { dg-options "-O3" } */ >=20=20 > #include > diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c= b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c > index 6ddd507d9cf..b20dec061b5 100644 > --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c > +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c > @@ -1,6 +1,6 @@ > /* We haven't implemented these intrinsics for arm yet. */ > -/* { dg-xfail-if "" { arm*-*-* } } */ > /* { dg-do run } */ > +/* { dg-skip-if "unsupported" { arm*-*-* } } */ > /* { dg-options "-O3" } */ >=20=20 > #include > diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c= b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c > index 451a0afc6aa..e59f845880e 100644 > --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c > +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c > @@ -1,6 +1,6 @@ > /* We haven't implemented these intrinsics for arm yet. */ > -/* { dg-xfail-if "" { arm*-*-* } } */ > /* { dg-do run } */ > +/* { dg-skip-if "unsupported" { arm*-*-* } } */ > /* { dg-options "-O3" } */ >=20=20 > #include