public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Sandiford <richard.sandiford@arm.com>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Cc: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>,
	GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] AArch64: Prioritise init_have_lse_atomics constructor [PR 105708]
Date: Wed, 25 May 2022 08:20:25 +0100	[thread overview]
Message-ID: <mptee0iqds6.fsf@arm.com> (raw)
In-Reply-To: <DB6PR0801MB18791C9A9C5C8213D039B75683D79@DB6PR0801MB1879.eurprd08.prod.outlook.com> (Wilco Dijkstra's message of "Tue, 24 May 2022 17:45:56 +0100")

Wilco Dijkstra <Wilco.Dijkstra@arm.com> writes:
> Increase the priority of the init_have_lse_atomics constructor so it runs
> before other constructors. This improves chances that rr works when LSE
> atomics are supported.

Can you add a comment above the function explaining why we chose 90
in particular?  I see 100 was originally suggested in the PR.

Thanks,
Richard

> Regress and bootstrap pass, OK for commit?
>
> 2022-05-24  Wilco Dijkstra  <wdijkstr@arm.com>
>
> libgcc/
>         PR libgcc/105708
>         * config/aarch64/lse-init.c: Increase constructor priority.
>
> ---
> diff --git a/libgcc/config/aarch64/lse-init.c b/libgcc/config/aarch64/lse-init.c
> index fc875b7fe80e947623e570eac130e7a14b516551..988882d91dfeed77f299aa610d72091499271490 100644
> --- a/libgcc/config/aarch64/lse-init.c
> +++ b/libgcc/config/aarch64/lse-init.c
> @@ -38,7 +38,7 @@ _Bool __aarch64_have_lse_atomics
>
>  unsigned long int __getauxval (unsigned long int);
>
> -static void __attribute__((constructor))
> +static void __attribute__((constructor (90)))
>  init_have_lse_atomics (void)
>  {
>    unsigned long hwcap = __getauxval (AT_HWCAP);

  reply	other threads:[~2022-05-25  7:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-24 16:45 Wilco Dijkstra
2022-05-25  7:20 ` Richard Sandiford [this message]
2022-05-25 10:42   ` Wilco Dijkstra
2022-05-25 11:57     ` Richard Sandiford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mptee0iqds6.fsf@arm.com \
    --to=richard.sandiford@arm.com \
    --cc=Kyrylo.Tkachov@arm.com \
    --cc=Wilco.Dijkstra@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).