From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 90A6C3874C30 for ; Thu, 11 Mar 2021 12:18:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 90A6C3874C30 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AF26131B; Thu, 11 Mar 2021 04:18:07 -0800 (PST) Received: from localhost (e121540-lin.manchester.arm.com [10.32.98.126]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1F7DA3F793; Thu, 11 Mar 2021 04:18:07 -0800 (PST) From: Richard Sandiford To: Richard Biener via Gcc-patches Mail-Followup-To: Richard Biener via Gcc-patches , Alexandre Oliva , Richard Biener , richard.sandiford@arm.com Cc: Alexandre Oliva , Richard Biener Subject: Re: [RFC] decay vect tests from run to link for pr95401 References: Date: Thu, 11 Mar 2021 12:17:59 +0000 In-Reply-To: (Richard Biener via Gcc-patches's message of "Thu, 11 Mar 2021 10:48:09 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_NUMSUBJECT, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2021 12:18:09 -0000 Richard Biener via Gcc-patches writes: > On Thu, Mar 11, 2021 at 9:03 AM Alexandre Oliva wrote: >> >> >> When vect.exp finds our configuration disables altivec by default, it >> disables the execution of vectorization tests, assuming the test >> hardware doesn't support it. >> >> Tests become just compile tests, but compile tests won't work >> correctly when additional sources are named, e.g. pr95401.cc, because >> GCC refuses to compile multiple files into the same asm output. >> >> With this patch, the default for when execution is not possible >> becomes link. >> >> >> This was regstrapped on x86_64-linux-gnu and ppc64-linux-gnu, and tested >> with a cross to a ppc64-vxworks7r2 with altivec disabled by default. I >> found fixing the handling of additional sources to e.g. compile each one >> separately, or perhaps just discard or reject additional sources for >> compile tests, to be a little too involved. >> >> So I'm leaning towards this proposed change, just extended to other >> platforms that also decay from run to compile rather than link, and thus >> run into this problem in g++.dg/vect/pr95401.cc. Would this be >> acceptable? > > I think that's OK. +1 FWIW. It seems like an improvement anyway, since it makes it harder to forget an explicit dg-do compile in cases where it's needed. Richard