From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <richard.sandiford@arm.com>
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by sourceware.org (Postfix) with ESMTP id AD5D93854817
 for <gcc-patches@gcc.gnu.org>; Mon,  4 Jan 2021 14:53:51 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AD5D93854817
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 44333101E;
 Mon,  4 Jan 2021 06:53:51 -0800 (PST)
Received: from localhost (e121540-lin.manchester.arm.com [10.32.98.126])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C3D623F719;
 Mon,  4 Jan 2021 06:53:50 -0800 (PST)
From: Richard Sandiford <richard.sandiford@arm.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Mail-Followup-To: Andreas Schwab <schwab@linux-m68k.org>,
 gcc-patches@gcc.gnu.org, richard.sandiford@arm.com
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [08/23] Add an alternative splay tree implementation
References: <mpth7ptad81.fsf@arm.com> <mptima98yfz.fsf@arm.com>
 <87o8i95aj4.fsf@linux-m68k.org>
Date: Mon, 04 Jan 2021 14:53:49 +0000
In-Reply-To: <87o8i95aj4.fsf@linux-m68k.org> (Andreas Schwab's message of
 "Fri, 01 Jan 2021 09:25:19 +0100")
Message-ID: <mpteej0hhxe.fsf@arm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jan 2021 14:53:54 -0000

Andreas Schwab <schwab@linux-m68k.org> writes:
> That doesn't build with gcc 4.8:

Which subversion are you using?  It works for me with stock gcc 4.8.5,
which is what I'd used to test the series for C++ compatiblity.

Richard

>
> In file included from ../../gcc/splay-tree-utils.h:491:0,
>                  from ../../gcc/rtl-ssa.h:45,
>                  from ../../gcc/fwprop.c:29:
> ../../gcc/splay-tree-utils.tcc:24:1: error: prototype for 'typename base_splay_tree<Accessors>::node_type base_splay_tree<Accessors>::get_child(typename Accessors::node_type, unsigned int)' does not match any in class 'base_splay_tree<Accessors>'
>  base_splay_tree<Accessors>::get_child (node_type node, unsigned int index)
>  ^
> In file included from ../../gcc/rtl-ssa.h:45:0,
>                  from ../../gcc/fwprop.c:29:
> ../../gcc/splay-tree-utils.h:125:20: error: candidate is: static typename Accessors::node_type base_splay_tree<Accessors>::get_child(typename Accessors::node_type, unsigned int)
>    static node_type get_child (node_type, unsigned int);
>                     ^
>
> Andreas.