From: Richard Sandiford <richard.sandiford@arm.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>,
"gcc-patches\@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] rtl-ssa: Include memmodel.h before tm_p.h
Date: Thu, 17 Dec 2020 14:04:04 +0000 [thread overview]
Message-ID: <mptft44pm0b.fsf@arm.com> (raw)
In-Reply-To: <yddeejoy22y.fsf@CeBiTec.Uni-Bielefeld.DE> (Rainer Orth's message of "Thu, 17 Dec 2020 14:49:41 +0100")
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:
> Hi Kyryll,
>
>>> Fixed by moving the memmove.h include in rtl-ssa.h before tm_p.h.
>>>
>>> Tested on sparc-sun-solaris2.11 and i386-pc-solaris2.11 (both into stage
>>> 3 now, so the compilation error is gone).
>>>
>>> Ok for master?
>>
>> AFAIK simple patches like this that fix build/bootstrap are viewed as
>> obvious and can be committed.
>> I hope I'm not wrong 😊
>
> I know, however I'm always unsure about the proper include order,
Me too TBH, as seen here. But I agree it looks like memmodel.h
has to be included before tm_p.h. It looks like some files
include emit-rtl.h without directly including tm_p.h (such as
auto-inc-dec.c) so maybe that tm_p.h include was needed for
something else. Or maybe auto-inc-dec.c gets it indirectly
via something else.
> thus asking for review.
OK, thanks, and sorry for the breakage.
Richard
prev parent reply other threads:[~2020-12-17 14:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 10:36 Rainer Orth
2020-12-17 13:41 ` Kyrylo Tkachov
2020-12-17 13:49 ` Rainer Orth
2020-12-17 14:04 ` Richard Sandiford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mptft44pm0b.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=Kyrylo.Tkachov@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).