From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 81D583858D33 for ; Thu, 2 Mar 2023 10:46:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 81D583858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 728F62F4; Thu, 2 Mar 2023 02:47:12 -0800 (PST) Received: from localhost (e121540-lin.manchester.arm.com [10.32.99.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BC3983F67D; Thu, 2 Mar 2023 02:46:28 -0800 (PST) From: Richard Sandiford To: Jonathan Yong <10walls@gmail.com> Mail-Followup-To: Jonathan Yong <10walls@gmail.com>,Jonathan Yong via Gcc-patches , richard.sandiford@arm.com Cc: Jonathan Yong via Gcc-patches Subject: Re: [Patch] gcc.dg/memchr-3.c: fix for LLP64 References: Date: Thu, 02 Mar 2023 10:46:27 +0000 In-Reply-To: (Jonathan Yong's message of "Wed, 1 Mar 2023 13:41:22 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-33.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_NUMSUBJECT,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Jonathan Yong <10walls@gmail.com> writes: > On 2/27/23 16:55, Richard Sandiford wrote: >> Jonathan Yong via Gcc-patches writes: >>> Attached patch OK? >>> >>> gcc.dg/memchr-3.c: fix for LLP64 >>> >>> gcc/testsuite/ChangeLog: >>> >>> PR middle-end/97956 >>> * gcc.dg/memchr-3.c (memchr): fix long to size_t in >>> prototype. >>> >>> From 194eb3d43964276beeaea14ebee4b241799cd966 Mon Sep 17 00:00:00 2001 >>> From: Jonathan Yong <10walls@gmail.com> >>> Date: Mon, 27 Feb 2023 10:02:32 +0000 >>> Subject: [PATCH] gcc.dg/memchr-3.c: fix for LLP64 >>> >>> gcc/testsuite/ChangeLog: >>> >>> PR middle-end/97956 >>> * gcc.dg/memchr-3.c (memchr): fix long to size_t in >>> prototype. >> >> It looks like the current type signature could have been a deliberate >> part of the test. I think we should just skip it for LLP64 instead. >> Preapproved if you agree. >> >> Thanks, >> Richard >> > > Revised, account for the warning in LLP64. > > > From 2dbfa538fe11c65914b28f94d066daee789f881a Mon Sep 17 00:00:00 2001 > From: Jonathan Yong <10walls@gmail.com> > Date: Mon, 27 Feb 2023 10:02:32 +0000 > Subject: [PATCH 6/7] gcc.dg/memchr-3.c: Account for LLP64 warnings > > gcc/testsuite/ChangeLog: > > PR middle-end/97956 > * gcc.dg/memchr-3.c (memchr): Account for LLP64 warnings. > > Signed-off-by: Jonathan Yong <10walls@gmail.com> > --- > gcc/testsuite/gcc.dg/memchr-3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.dg/memchr-3.c b/gcc/testsuite/gcc.dg/memchr-3.c > index c38d9cf3349..af1b26ef3ae 100644 > --- a/gcc/testsuite/gcc.dg/memchr-3.c > +++ b/gcc/testsuite/gcc.dg/memchr-3.c > @@ -6,7 +6,7 @@ > typedef __INT8_TYPE__ int8_t; > typedef __INT32_TYPE__ int32_t; > > -extern void* memchr (const void*, int, long); > +extern void* memchr (const void*, int, long); /* { dg-warning "-Wbuiltin-declaration-mismatch" { target llp64 } } */ > > struct SX > { OK, thanks. Richard