From: Richard Sandiford <richard.sandiford@arm.com>
To: Palmer Dabbelt <palmer@rivosinc.com>
Cc: Vineet Gupta <vineetg@rivosinc.com>,
gcc-patches@gcc.gnu.org, Kito Cheng <kito.cheng@gmail.com>,
jeffreyalaw@gmail.com, gnu-toolchain@rivosinc.com
Subject: Re: [PATCH] MAINTAINERS: add Vineet Gupta to write after approval
Date: Fri, 21 Apr 2023 10:30:40 +0100 [thread overview]
Message-ID: <mptildpa8fz.fsf@arm.com> (raw)
In-Reply-To: <mhng-c7073b46-56c5-4e6f-ae7f-84aa2f254426@palmer-ri-x1c9a> (Palmer Dabbelt's message of "Thu, 20 Apr 2023 10:31:07 -0700 (PDT)")
Palmer Dabbelt <palmer@rivosinc.com> writes:
> On Thu, 20 Apr 2023 09:55:23 PDT (-0700), Vineet Gupta wrote:
>> ChangeLog:
>>
>> * MAINTAINERS (Write After Approval): Add myself.
>>
>> (Ref: <680c7bbe-5d6e-07cd-8468-247afc65e1dd@gmail.com>)
>>
>> Signed-off-by: Vineet Gupta <vineetg@rivosinc.com>
>> ---
>> MAINTAINERS | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index cebf45d49e56..5f25617212a5 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -434,6 +434,7 @@ Haochen Gui <guihaoc@gcc.gnu.org>
>> Jiufu Guo <guojiufu@linux.ibm.com>
>> Xuepeng Guo <terry.xpguo@gmail.com>
>> Wei Guozhi <carrot@google.com>
>> +Vineet Gupta <vineetg@rivosinc.com>
>> Naveen H.S <naveenh@marvell.com>
>> Mostafa Hagog <hagog@gcc.gnu.org>
>> Andrew Haley <aph@redhat.com>
>
> Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
>
> Though not sure if I can do that, maybe we need a global reviewer?
No approval is needed when adding oneself to write-after-approval.
The fact that one's able to make the change is proof enough.
Richard
next prev parent reply other threads:[~2023-04-21 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 16:55 Vineet Gupta
2023-04-20 17:31 ` Palmer Dabbelt
2023-04-21 9:30 ` Richard Sandiford [this message]
2023-04-21 16:00 ` Vineet Gupta
2023-04-21 16:03 ` Kito Cheng
2023-04-21 16:09 ` [committed] " Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mptildpa8fz.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gnu-toolchain@rivosinc.com \
--cc=jeffreyalaw@gmail.com \
--cc=kito.cheng@gmail.com \
--cc=palmer@rivosinc.com \
--cc=vineetg@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).