From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=hHZj=AM=arm.com=richard.sandiford@sourceware.org>
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
	by sourceware.org (Postfix) with ESMTP id 2378B3858D37
	for <gcc-patches@gcc.gnu.org>; Fri, 21 Apr 2023 09:30:43 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2378B3858D37
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 918201480;
	Fri, 21 Apr 2023 02:31:26 -0700 (PDT)
Received: from localhost (e121540-lin.manchester.arm.com [10.32.110.72])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D16EB3F5A1;
	Fri, 21 Apr 2023 02:30:41 -0700 (PDT)
From: Richard Sandiford <richard.sandiford@arm.com>
To: Palmer Dabbelt <palmer@rivosinc.com>
Mail-Followup-To: Palmer Dabbelt <palmer@rivosinc.com>,Vineet Gupta <vineetg@rivosinc.com>,  gcc-patches@gcc.gnu.org,  Kito Cheng <kito.cheng@gmail.com>,  jeffreyalaw@gmail.com,  gnu-toolchain@rivosinc.com, richard.sandiford@arm.com
Cc: Vineet Gupta <vineetg@rivosinc.com>,  gcc-patches@gcc.gnu.org,  Kito Cheng <kito.cheng@gmail.com>,  jeffreyalaw@gmail.com,  gnu-toolchain@rivosinc.com
Subject: Re: [PATCH] MAINTAINERS: add Vineet Gupta to write after approval
References: <mhng-c7073b46-56c5-4e6f-ae7f-84aa2f254426@palmer-ri-x1c9a>
Date: Fri, 21 Apr 2023 10:30:40 +0100
In-Reply-To: <mhng-c7073b46-56c5-4e6f-ae7f-84aa2f254426@palmer-ri-x1c9a>
	(Palmer Dabbelt's message of "Thu, 20 Apr 2023 10:31:07 -0700 (PDT)")
Message-ID: <mptildpa8fz.fsf@arm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-30.7 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

Palmer Dabbelt <palmer@rivosinc.com> writes:
> On Thu, 20 Apr 2023 09:55:23 PDT (-0700), Vineet Gupta wrote:
>> ChangeLog:
>>
>> 	* MAINTAINERS (Write After Approval): Add myself.
>>
>> (Ref: <680c7bbe-5d6e-07cd-8468-247afc65e1dd@gmail.com>)
>>
>> Signed-off-by: Vineet Gupta <vineetg@rivosinc.com>
>> ---
>>  MAINTAINERS | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index cebf45d49e56..5f25617212a5 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -434,6 +434,7 @@ Haochen Gui					<guihaoc@gcc.gnu.org>
>>  Jiufu Guo					<guojiufu@linux.ibm.com>
>>  Xuepeng Guo					<terry.xpguo@gmail.com>
>>  Wei Guozhi					<carrot@google.com>
>> +Vineet Gupta					<vineetg@rivosinc.com>
>>  Naveen H.S					<naveenh@marvell.com>
>>  Mostafa Hagog					<hagog@gcc.gnu.org>
>>  Andrew Haley					<aph@redhat.com>
>
> Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
>
> Though not sure if I can do that, maybe we need a global reviewer?

No approval is needed when adding oneself to write-after-approval.
The fact that one's able to make the change is proof enough.

Richard