From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=5ypL=AL=arm.com=richard.sandiford@sourceware.org>
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
	by sourceware.org (Postfix) with ESMTP id 030E13858D37
	for <gcc-patches@gcc.gnu.org>; Thu, 20 Apr 2023 10:01:27 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 030E13858D37
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5FCA11480;
	Thu, 20 Apr 2023 03:02:10 -0700 (PDT)
Received: from localhost (e121540-lin.manchester.arm.com [10.32.110.72])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6B1F53F587;
	Thu, 20 Apr 2023 03:01:25 -0700 (PDT)
From: Richard Sandiford <richard.sandiford@arm.com>
To: <juzhe.zhong@rivai.ai>
Mail-Followup-To: <juzhe.zhong@rivai.ai>,kito.cheng <kito.cheng@gmail.com>,  richard.guenther <richard.guenther@gmail.com>,  "Jeff Law" <jeffreyalaw@gmail.com>,  palmer <palmer@dabbelt.com>,  "Michael Collison" <collison@rivosinc.com>,  gcc-patches <gcc-patches@gcc.gnu.org>, richard.sandiford@arm.com
Cc: kito.cheng <kito.cheng@gmail.com>,  richard.guenther <richard.guenther@gmail.com>,  "Jeff Law" <jeffreyalaw@gmail.com>,  palmer <palmer@dabbelt.com>,  "Michael Collison" <collison@rivosinc.com>,  gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH v4 07/10] vect: Verify that GET_MODE_NUNITS is a multiple of 2.
References: <20230417183701.2249183-1-collison@rivosinc.com>
	<20230417183701.2249183-8-collison@rivosinc.com>
	<CAFiYyc1gj4k4mPLNiqCdqFzNpiYctutDB0+o5yXeaWAVG74f3w@mail.gmail.com>
	<CA+yXCZD6DaH43OSd5WKKYy-LSMCVkCi3OYZgFUx2ERbskDWf1g@mail.gmail.com>
	<CA+yXCZAsJ9cXZV6crK5DWd=3Fg=_YBrFcLGmQe-c9cczU2Jigg@mail.gmail.com>
	<FF8B40A3142277E8+202304190648511512504@rivai.ai>
Date: Thu, 20 Apr 2023 11:01:24 +0100
In-Reply-To: <FF8B40A3142277E8+202304190648511512504@rivai.ai> (juzhe zhong's
	message of "Wed, 19 Apr 2023 06:48:51 +0800")
Message-ID: <mptildqdg97.fsf@arm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-23.6 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_LINKBAIT,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

<juzhe.zhong@rivai.ai> writes:
> Yes, like kito said.
> We won't enable VNx1DImode in auto-vectorization so it's meaningless to fix it here.
> We dynamic adjust the minimum vector-length for different '-march' according to RVV ISA specification.
> So we strongly suggest that we should drop this fix.

I think the patch should go in regardless.  If we have a port with
a VNx1 mode then the exact_div is at best dubious and at worst wrong.

Thanks,
Richard