From: Richard Sandiford <richard.sandiford@arm.com>
To: Richard Ball <richard.ball@arm.com>
Cc: gcc-patches@gcc.gnu.org, richard.earnshaw@arm.com,
marcus.shawcroft@arm.com, kyrylo.tkachov@arm.com
Subject: Re: [PATCH] aarch64: Replace manual swapping idiom with std::swap in aarch64.cc
Date: Mon, 18 Jul 2022 11:30:51 +0100 [thread overview]
Message-ID: <mptilnuvhk4.fsf@arm.com> (raw)
In-Reply-To: <cf6b3c07-ef80-a8e9-ca7c-e935a7937338@arm.com> (Richard Ball's message of "Fri, 15 Jul 2022 15:53:41 +0100")
Richard Ball <richard.ball@arm.com> writes:
> Replace manual swapping idiom with std::swap in aarch64.cc
>
> gcc/config/aarch64/aarch64.cc has a few manual swapping idioms of the form:
>
> x = in0, in0 = in1, in1 = x;
>
> The preferred way is using the standard:
>
> std::swap (in0, in1);
>
> We should just fix these to use std::swap.
> This will also allow us to eliminate the x temporary rtx.
>
> gcc/ChangeLog:
>
> * config/aarch64/aarch64.cc (aarch64_evpc_trn): Use std:swap.
> (aarch64_evpc_uzp): Likewise.
> (aarch64_evpc_zip): Likewise.
Thanks, pushed to trunk.
Richard
> ---
>
>
> diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc
> index
> d049f9a9819628a73bfd57114c3b89d848da7d9c..b75a032c2f2c55d71bcb6b4b6ef1bd7f42a97235
> 100644
> --- a/gcc/config/aarch64/aarch64.cc
> +++ b/gcc/config/aarch64/aarch64.cc
> @@ -23498,7 +23498,7 @@ aarch64_evpc_trn (struct expand_vec_perm_d *d)
> {
> HOST_WIDE_INT odd;
> poly_uint64 nelt = d->perm.length ();
> - rtx out, in0, in1, x;
> + rtx out, in0, in1;
> machine_mode vmode = d->vmode;
>
> if (GET_MODE_UNIT_SIZE (vmode) > 8)
> @@ -23522,7 +23522,7 @@ aarch64_evpc_trn (struct expand_vec_perm_d *d)
> at the head of aarch64-sve.md for details. */
> if (BYTES_BIG_ENDIAN && d->vec_flags == VEC_ADVSIMD)
> {
> - x = in0, in0 = in1, in1 = x;
> + std::swap (in0, in1);
> odd = !odd;
> }
> out = d->target;
> @@ -23592,7 +23592,7 @@ static bool
> aarch64_evpc_uzp (struct expand_vec_perm_d *d)
> {
> HOST_WIDE_INT odd;
> - rtx out, in0, in1, x;
> + rtx out, in0, in1;
> machine_mode vmode = d->vmode;
>
> if (GET_MODE_UNIT_SIZE (vmode) > 8)
> @@ -23615,7 +23615,7 @@ aarch64_evpc_uzp (struct expand_vec_perm_d *d)
> at the head of aarch64-sve.md for details. */
> if (BYTES_BIG_ENDIAN && d->vec_flags == VEC_ADVSIMD)
> {
> - x = in0, in0 = in1, in1 = x;
> + std::swap (in0, in1);
> odd = !odd;
> }
> out = d->target;
> @@ -23631,7 +23631,7 @@ aarch64_evpc_zip (struct expand_vec_perm_d *d)
> {
> unsigned int high;
> poly_uint64 nelt = d->perm.length ();
> - rtx out, in0, in1, x;
> + rtx out, in0, in1;
> machine_mode vmode = d->vmode;
>
> if (GET_MODE_UNIT_SIZE (vmode) > 8)
> @@ -23656,7 +23656,7 @@ aarch64_evpc_zip (struct expand_vec_perm_d *d)
> at the head of aarch64-sve.md for details. */
> if (BYTES_BIG_ENDIAN && d->vec_flags == VEC_ADVSIMD)
> {
> - x = in0, in0 = in1, in1 = x;
> + std::swap (in0, in1);
> high = !high;
> }
> out = d->target;
prev parent reply other threads:[~2022-07-18 10:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 14:53 Richard Ball
2022-07-18 10:30 ` Richard Sandiford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mptilnuvhk4.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
--cc=marcus.shawcroft@arm.com \
--cc=richard.ball@arm.com \
--cc=richard.earnshaw@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).