From: Richard Sandiford <richard.sandiford@arm.com>
To: Jonathan Wright <Jonathan.Wright@arm.com>
Cc: "gcc-patches\@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Christophe Lyon <christophe.lyon.oss@gmail.com>
Subject: Re: [PATCH] testsuite: aarch64: Fix failing vector structure tests on big-endian
Date: Fri, 06 Aug 2021 13:24:29 +0100 [thread overview]
Message-ID: <mptim0izrpe.fsf@arm.com> (raw)
In-Reply-To: <DB9PR08MB69598A1B8E644C5DC4AB8087EBF19@DB9PR08MB6959.eurprd08.prod.outlook.com> (Jonathan Wright's message of "Wed, 4 Aug 2021 11:05:18 +0100")
Jonathan Wright <Jonathan.Wright@arm.com> writes:
> diff --git a/gcc/testsuite/gcc.target/aarch64/vector_structure_intrinsics.c b/gcc/testsuite/gcc.target/aarch64/vector_structure_intrinsics.c
> index 60c53bc27f8378c78b119576ed19fde0e5743894..a8e31ab85d6fd2a045c8efaf2cbc42b5f40d2411 100644
> --- a/gcc/testsuite/gcc.target/aarch64/vector_structure_intrinsics.c
> +++ b/gcc/testsuite/gcc.target/aarch64/vector_structure_intrinsics.c
> @@ -197,7 +197,8 @@ TEST_ST1x3 (vst1q, uint64x2x3_t, uint64_t*, u64, x3);
> TEST_ST1x3 (vst1q, poly64x2x3_t, poly64_t*, p64, x3);
> TEST_ST1x3 (vst1q, float64x2x3_t, float64_t*, f64, x3);
>
> -/* { dg-final { scan-assembler-not "mov\\t" } } */
> +/* { dg-final { scan-assembler-not {"mov\\t"} {
> + target { aarch64_little_endian } } ) } */
I think this needs to stay on line. We should also either keep the
original quoting on the regexp or use {mov\t}. Having both forms
of quote would turn it into a test for the characters:
"mov\t"
(including quotes and backslash).
Thanks,
Richard
>
> /* { dg-final { scan-assembler-times "tbl\\t" 18} } */
> /* { dg-final { scan-assembler-times "tbx\\t" 18} } */
next prev parent reply other threads:[~2021-08-06 12:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 8:21 [PATCH 1/8] aarch64: Use memcpy to copy vector tables in vqtbl[234] intrinsics Jonathan Wright
2021-07-23 9:15 ` Kyrylo Tkachov
2021-08-03 9:42 ` Christophe Lyon
2021-08-04 10:05 ` [PATCH] testsuite: aarch64: Fix failing vector structure tests on big-endian Jonathan Wright
2021-08-06 12:24 ` Richard Sandiford [this message]
2021-08-09 8:41 ` Jonathan Wright
2021-08-09 8:43 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mptim0izrpe.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=Jonathan.Wright@arm.com \
--cc=christophe.lyon.oss@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).