From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 36CF0386103C for ; Tue, 13 Oct 2020 16:04:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 36CF0386103C Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DDA7F31B; Tue, 13 Oct 2020 09:04:05 -0700 (PDT) Received: from localhost (e121540-lin.manchester.arm.com [10.32.98.126]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7D78E3F66B; Tue, 13 Oct 2020 09:04:04 -0700 (PDT) From: Richard Sandiford To: Matthew Malcomson Mail-Followup-To: Matthew Malcomson , gcc-patches@gcc.gnu.org, "kcc\@google.com" , Richard Earnshaw , "jakub\@redhat.com" , "joseph\@codesourcery.com" , "dvyukov\@google.com" , Kyrylo Tkachov , "dodji\@redhat.com" , Martin Liska , richard.sandiford@arm.com Cc: gcc-patches@gcc.gnu.org, "kcc\@google.com" , Richard Earnshaw , "jakub\@redhat.com" , "joseph\@codesourcery.com" , "dvyukov\@google.com" , Kyrylo Tkachov , "dodji\@redhat.com" , Martin Liska Subject: Re: [PATCH 2/X] libsanitizer: Only build libhwasan when targeting AArch64 References: <159733217227.27989.12562557223197015866.scripted-patch-series@arm.com> <157295142743.27946.1142544630216676787.scripted-patch-series@arm.com> <157616229728.30610.11942820198797258041.scripted-patch-series@arm.com> Date: Tue, 13 Oct 2020 17:04:02 +0100 In-Reply-To: (Matthew Malcomson's message of "Mon, 17 Aug 2020 15:13:00 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_NUMSUBJECT, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Oct 2020 16:04:07 -0000 Matthew Malcomson writes: > diff --git a/libsanitizer/configure.tgt b/libsanitizer/configure.tgt > index 52503f1a880ba08b515b8a429ac44a262873f74b..fb55ae9762e9ac6531087a258e1291b5635fcd3e 100644 > --- a/libsanitizer/configure.tgt > +++ b/libsanitizer/configure.tgt > @@ -61,6 +61,7 @@ case "${target}" in > LSAN_SUPPORTED=yes > TSAN_TARGET_DEPENDENT_OBJECTS=tsan_rtl_aarch64.lo > fi > + HWASAN_SUPPORTED=yes > ;; > x86_64-*-darwin1[2-9]* | i?86-*-darwin1[2-9]*) > TSAN_SUPPORTED=no It might be worth having a comment here to emphasise that hwasan is supported for both ILP32 and LP64. OK with or without that change in combination with the other patches. Thanks, Richard