From: Richard Sandiford <richard.sandiford@arm.com>
To: Dimitar Dimitrov <dimitar@dinux.eu>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 2/4] testsuite: Add expected warning for packed attribute
Date: Mon, 20 Jul 2020 18:54:50 +0100 [thread overview]
Message-ID: <mptimeiysut.fsf@arm.com> (raw)
In-Reply-To: <20200720163106.27849-3-dimitar@dinux.eu> (Dimitar Dimitrov's message of "Mon, 20 Jul 2020 19:31:04 +0300")
Dimitar Dimitrov <dimitar@dinux.eu> writes:
> Targets which pack structures by default get warnings for packed structure
> attributes. This is expected, so add markers in the test cases.
>
> gcc/testsuite/ChangeLog:
>
> * c-c++-common/Waddress-of-packed-member-2.c: Add dg-warning for
> ignored attribute if target is default_packed.
> * c-c++-common/Wattributes.c: Ditto.
> * c-c++-common/attr-copy.c: Ditto.
> * c-c++-common/builtin-has-attribute-4.c: Ditto.
> * c-c++-common/pr51628-29.c: Ditto.
> * c-c++-common/pr51628-30.c: Ditto.
> * c-c++-common/pr51628-32.c: Ditto.
> * gcc.dg/Wattributes-6.c: Ditto.
> * gcc.dg/attr-copy-4.c: Ditto.
> * gcc.dg/attr-copy-8.c: Ditto.
OK, thanks. I wondered whether we should handle this in prune.exp,
but there's no precedent that I can see for doing that based on
target selectors. The number of affected tests is also pretty small,
so it might not have been worth it anyway.
Thanks,
Richard
next prev parent reply other threads:[~2020-07-20 17:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 16:31 [PATCH 0/4] testsuite: Add markers for default_packed targets Dimitar Dimitrov
2020-07-20 16:31 ` [PATCH 1/4] testsuite: Filter unaligned pointer value warning Dimitar Dimitrov
2020-07-20 17:51 ` Richard Sandiford
2020-07-20 16:31 ` [PATCH 2/4] testsuite: Add expected warning for packed attribute Dimitar Dimitrov
2020-07-20 17:54 ` Richard Sandiford [this message]
2020-07-20 16:31 ` [PATCH 3/4] testsuite: Relax pattern to include "packed" targets Dimitar Dimitrov
2020-07-20 17:56 ` Richard Sandiford
2020-07-20 16:31 ` [PATCH 4/4] testsuite: Add default_packed filters Dimitar Dimitrov
2020-07-20 17:57 ` Richard Sandiford
2020-07-21 15:58 ` [PATCH 0/4] testsuite: Add markers for default_packed targets Dimitar Dimitrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mptimeiysut.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=dimitar@dinux.eu \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).