From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 3846D3851C39 for ; Mon, 20 Jul 2020 17:54:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3846D3851C39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=richard.sandiford@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E0F19106F; Mon, 20 Jul 2020 10:54:52 -0700 (PDT) Received: from localhost (e121540-lin.manchester.arm.com [10.32.98.126]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6D1AC3F66F; Mon, 20 Jul 2020 10:54:52 -0700 (PDT) From: Richard Sandiford To: Dimitar Dimitrov Mail-Followup-To: Dimitar Dimitrov , gcc-patches@gcc.gnu.org, richard.sandiford@arm.com Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 2/4] testsuite: Add expected warning for packed attribute References: <20200720163106.27849-1-dimitar@dinux.eu> <20200720163106.27849-3-dimitar@dinux.eu> Date: Mon, 20 Jul 2020 18:54:50 +0100 In-Reply-To: <20200720163106.27849-3-dimitar@dinux.eu> (Dimitar Dimitrov's message of "Mon, 20 Jul 2020 19:31:04 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jul 2020 17:54:54 -0000 Dimitar Dimitrov writes: > Targets which pack structures by default get warnings for packed structure > attributes. This is expected, so add markers in the test cases. > > gcc/testsuite/ChangeLog: > > * c-c++-common/Waddress-of-packed-member-2.c: Add dg-warning for > ignored attribute if target is default_packed. > * c-c++-common/Wattributes.c: Ditto. > * c-c++-common/attr-copy.c: Ditto. > * c-c++-common/builtin-has-attribute-4.c: Ditto. > * c-c++-common/pr51628-29.c: Ditto. > * c-c++-common/pr51628-30.c: Ditto. > * c-c++-common/pr51628-32.c: Ditto. > * gcc.dg/Wattributes-6.c: Ditto. > * gcc.dg/attr-copy-4.c: Ditto. > * gcc.dg/attr-copy-8.c: Ditto. OK, thanks. I wondered whether we should handle this in prune.exp, but there's no precedent that I can see for doing that based on target selectors. The number of affected tests is also pretty small, so it might not have been worth it anyway. Thanks, Richard