From: Richard Sandiford <richard.sandiford@arm.com>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
Subject: Re: [PATCH] libatomic: Fix build for --disable-gnu-indirect-function [PR113986]
Date: Thu, 04 Apr 2024 13:31:41 +0100 [thread overview]
Message-ID: <mptjzldxqaa.fsf@arm.com> (raw)
In-Reply-To: <DB3PR08MB8986BFAB31278A1A97F98A4883352@DB3PR08MB8986.eurprd08.prod.outlook.com> (Wilco Dijkstra's message of "Tue, 26 Mar 2024 11:55:41 +0000")
Wilco Dijkstra <Wilco.Dijkstra@arm.com> writes:
> v2:
>
> Fix libatomic build to support --disable-gnu-indirect-function on AArch64.
> Always build atomic_16.S, add aliases to the __atomic_ functions if !HAVE_IFUNC.
> Include auto-config.h in atomic_16.S to avoid having to pass defines via makefiles.
> Fix build if HWCAP_ATOMICS/CPUID are not defined.
>
> Passes regress and bootstrap, OK for commit?
>
> libatomic:
> PR target/113986
> * Makefile.in: Regenerated.
> * Makefile.am: Make atomic_16.S not depend on HAVE_IFUNC.
> Remove predefine of HAVE_FEAT_LSE128.
> * acinclude.m4: Remove ARCH_AARCH64_HAVE_LSE128.
> * configure: Regenerated.
> * config/linux/aarch64/atomic_16.S: Add __atomic_ aliases if !HAVE_IFUNC.
> * config/linux/aarch64/host-config.h: Correctly handle !HAVE_IFUNC. Add
> defines for HWCAP_ATOMICS and HWCAP_CPUID.
OK, thanks, but...
> @@ -35,7 +48,6 @@ typedef struct __ifunc_arg_t {
> # define _IFUNC_ARG_HWCAP (1ULL << 62)
> #endif
>
> -#ifdef HWCAP_USCAT
> # if N == 16
> # define IFUNC_COND_1 (has_lse128 (hwcap, features))
> # define IFUNC_COND_2 (has_lse2 (hwcap, features))
> @@ -44,19 +56,6 @@ typedef struct __ifunc_arg_t {
> # define IFUNC_COND_1 (hwcap & HWCAP_ATOMICS)
> # define IFUNC_NCOND(N) 1
> # endif
...please reindent this block so that there is no space after the
"#" in the outermost directives.
Richard
next prev parent reply other threads:[~2024-04-04 12:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 16:39 Wilco Dijkstra
2024-03-07 20:51 ` Richard Sandiford
2024-03-26 11:55 ` Wilco Dijkstra
2024-04-04 12:31 ` Richard Sandiford [this message]
2024-04-05 10:18 ` [committed] libatomic: Regenerate configure properly Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mptjzldxqaa.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=Kyrylo.Tkachov@arm.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).