public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Sandiford <richard.sandiford@arm.com>
To: "yanzhang.wang--- via Gcc-patches" <gcc-patches@gcc.gnu.org>
Cc: yanzhang.wang@intel.com,  apinski@marvell.com,
	 juzhe.zhong@rivai.ai,  kito.cheng@sifive.com
Subject: Re: [PATCH] Bug 111071: fix the subr with -1 to not due to the simplify.
Date: Mon, 04 Sep 2023 16:21:41 +0100	[thread overview]
Message-ID: <mptjzt6vu9m.fsf@arm.com> (raw)
In-Reply-To: <20230830011256.1898667-1-yanzhang.wang@intel.com> (yanzhang wang's message of "Wed, 30 Aug 2023 09:09:04 +0800")

"yanzhang.wang--- via Gcc-patches" <gcc-patches@gcc.gnu.org> writes:
> From: Yanzhang Wang <yanzhang.wang@intel.com>
>
> gcc/testsuite/ChangeLog:
>
> 	* gcc.target/aarch64/sve/acle/asm/subr_s8.c: Modify subr with -1
>     to not.
>
> Signed-off-by: Yanzhang Wang <yanzhang.wang@intel.com>
> ---
>
> Tested on my local arm environment and passed. Thanks Andrew Pinski's comment
> the code is the same with that.
>
>  gcc/testsuite/gcc.target/aarch64/sve/acle/asm/subr_s8.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/asm/subr_s8.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/asm/subr_s8.c
> index b9615de6655..1cf6916a5e0 100644
> --- a/gcc/testsuite/gcc.target/aarch64/sve/acle/asm/subr_s8.c
> +++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/asm/subr_s8.c
> @@ -76,8 +76,7 @@ TEST_UNIFORM_Z (subr_1_s8_m_untied, svint8_t,
>  
>  /*
>  ** subr_m1_s8_m:
> -**	mov	(z[0-9]+\.b), #-1
> -**	subr	z0\.b, p0/m, z0\.b, \1
> +**	not	z0.b, p0/m, z0.b
>  **	ret
>  */
>  TEST_UNIFORM_Z (subr_m1_s8_m, svint8_t,

I think we need this for subr_u8.c too.  OK with that change,
and thanks for the fix!

Richard

  reply	other threads:[~2023-09-04 15:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-30  1:09 yanzhang.wang
2023-09-04 15:21 ` Richard Sandiford [this message]
2023-09-04 18:59   ` Richard Sandiford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mptjzt6vu9m.fsf@arm.com \
    --to=richard.sandiford@arm.com \
    --cc=apinski@marvell.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=juzhe.zhong@rivai.ai \
    --cc=kito.cheng@sifive.com \
    --cc=yanzhang.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).