From: Richard Sandiford <richard.sandiford@arm.com>
To: "H.J. Lu via Gcc-patches" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] by_pieces: Properly set m_max_size in op_by_pieces
Date: Wed, 04 Aug 2021 08:27:40 +0100 [thread overview]
Message-ID: <mptmtpxacur.fsf@arm.com> (raw)
In-Reply-To: <CAMe9rOqW9_kusFySD=WpV1pZHwHnHrnhLv2ZDsZfz0XGbk8pPQ@mail.gmail.com> (H. J. Lu via Gcc-patches's message of "Tue, 3 Aug 2021 14:22:59 -0700")
"H.J. Lu via Gcc-patches" <gcc-patches@gcc.gnu.org> writes:
> @@ -1122,8 +1122,8 @@ class op_by_pieces_d
> and its associated FROM_CFN_DATA can be used to replace loads with
> constant values. LEN describes the length of the operation. */
>
> -op_by_pieces_d::op_by_pieces_d (rtx to, bool to_load,
> - rtx from, bool from_load,
> +op_by_pieces_d::op_by_pieces_d (unsigned int max_pieces, rtx to,
> + bool to_load, rtx from, bool from_load,
> by_pieces_constfn from_cfn,
> void *from_cfn_data,
> unsigned HOST_WIDE_INT len,
The comment above the function needs to describe the new parameter.
OK with that change, thanks.
Richard
next prev parent reply other threads:[~2021-08-04 7:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 13:56 H.J. Lu
2021-08-03 21:22 ` H.J. Lu
2021-08-04 7:27 ` Richard Sandiford [this message]
2021-08-04 12:52 ` [PATCH v2] by_pieces: Pass MAX_PIECES to op_by_pieces_d H.J. Lu
2021-08-04 13:33 ` [PATCH v2] x86: Update STORE_MAX_PIECES H.J. Lu
2021-08-04 18:46 ` Uros Bizjak
2021-08-04 20:01 ` [PATCH v3] " H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mptmtpxacur.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).