From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <richard.sandiford@arm.com>
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by sourceware.org (Postfix) with ESMTP id 398313858413
 for <gcc-patches@gcc.gnu.org>; Wed,  4 Aug 2021 07:27:42 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 398313858413
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C764611FB;
 Wed,  4 Aug 2021 00:27:41 -0700 (PDT)
Received: from localhost (e121540-lin.manchester.arm.com [10.32.98.126])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4C7083F66F;
 Wed,  4 Aug 2021 00:27:41 -0700 (PDT)
From: Richard Sandiford <richard.sandiford@arm.com>
To: "H.J. Lu via Gcc-patches" <gcc-patches@gcc.gnu.org>
Mail-Followup-To: "H.J. Lu via Gcc-patches" <gcc-patches@gcc.gnu.org>,
 "H.J. Lu" <hjl.tools@gmail.com>, richard.sandiford@arm.com
Subject: Re: [PATCH] by_pieces: Properly set m_max_size in op_by_pieces
References: <20210803135646.2545430-1-hjl.tools@gmail.com>
 <CAMe9rOqW9_kusFySD=WpV1pZHwHnHrnhLv2ZDsZfz0XGbk8pPQ@mail.gmail.com>
Date: Wed, 04 Aug 2021 08:27:40 +0100
In-Reply-To: <CAMe9rOqW9_kusFySD=WpV1pZHwHnHrnhLv2ZDsZfz0XGbk8pPQ@mail.gmail.com>
 (H. J. Lu via Gcc-patches's message of "Tue, 3 Aug 2021 14:22:59
 -0700")
Message-ID: <mptmtpxacur.fsf@arm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Aug 2021 07:27:43 -0000

"H.J. Lu via Gcc-patches" <gcc-patches@gcc.gnu.org> writes:
> @@ -1122,8 +1122,8 @@ class op_by_pieces_d
>     and its associated FROM_CFN_DATA can be used to replace loads with
>     constant values.  LEN describes the length of the operation.  */
> 
> -op_by_pieces_d::op_by_pieces_d (rtx to, bool to_load,
> -				rtx from, bool from_load,
> +op_by_pieces_d::op_by_pieces_d (unsigned int max_pieces, rtx to,
> +				bool to_load, rtx from, bool from_load,
>  				by_pieces_constfn from_cfn,
>  				void *from_cfn_data,
>  				unsigned HOST_WIDE_INT len,

The comment above the function needs to describe the new parameter.

OK with that change, thanks.

Richard