From: Richard Sandiford <richard.sandiford@arm.com>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH v2 2/7] aarch64: Do not force a stack frame for EH returns
Date: Sun, 26 Nov 2023 12:12:05 +0000 [thread overview]
Message-ID: <mpto7fgzpbe.fsf@arm.com> (raw)
In-Reply-To: <ae13c81e51afd2f628af10485d286b3dc7ab8daa.1699025214.git.szabolcs.nagy@arm.com> (Szabolcs Nagy's message of "Fri, 3 Nov 2023 15:36:14 +0000")
Szabolcs Nagy <szabolcs.nagy@arm.com> writes:
> EH returns no longer rely on clobbering the return address on the stack
> so forcing a stack frame is not necessary.
>
> This does not actually change the code gen for the unwinder since there
> are calls before the EH return.
>
> gcc/ChangeLog:
>
> * config/aarch64/aarch64.cc (aarch64_needs_frame_chain): Do not
> force frame chain for eh_return.
OK, thanks.
Richard
> ---
> unchanged compared to v1
> already approved at:
> https://gcc.gnu.org/pipermail/gcc-patches/2023-September/629346.html
> ---
> gcc/config/aarch64/aarch64.cc | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc
> index 5cdb33dd3dc..88594bed8ce 100644
> --- a/gcc/config/aarch64/aarch64.cc
> +++ b/gcc/config/aarch64/aarch64.cc
> @@ -8492,8 +8492,7 @@ aarch64_output_probe_sve_stack_clash (rtx base, rtx adjustment,
> static bool
> aarch64_needs_frame_chain (void)
> {
> - /* Force a frame chain for EH returns so the return address is at FP+8. */
> - if (frame_pointer_needed || crtl->calls_eh_return)
> + if (frame_pointer_needed)
> return true;
>
> /* A leaf function cannot have calls or write LR. */
next prev parent reply other threads:[~2023-11-26 12:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 15:36 [PATCH v2 0/7] aarch64 GCS preliminary patches Szabolcs Nagy
2023-11-03 15:36 ` [PATCH v2 1/7] aarch64: Use br instead of ret for eh_return Szabolcs Nagy
2023-11-13 0:27 ` Hans-Peter Nilsson
2023-11-13 11:18 ` Szabolcs Nagy
2023-11-26 12:11 ` Richard Sandiford
2023-11-03 15:36 ` [PATCH v2 2/7] aarch64: Do not force a stack frame for EH returns Szabolcs Nagy
2023-11-26 12:12 ` Richard Sandiford [this message]
2023-11-03 15:36 ` [PATCH v2 3/7] aarch64: Add eh_return compile tests Szabolcs Nagy
2023-11-26 14:37 ` Richard Sandiford
2023-11-27 10:04 ` Szabolcs Nagy
2023-11-27 15:57 ` Szabolcs Nagy
2023-12-02 19:23 ` Andrew Pinski
2023-11-03 15:36 ` [PATCH v2 4/7] aarch64: Disable branch-protection for pcs tests Szabolcs Nagy
2023-11-03 15:36 ` [PATCH v2 5/7] aarch64,arm: Remove accepted_branch_protection_string Szabolcs Nagy
2023-11-26 14:50 ` Richard Sandiford
2023-11-03 15:36 ` [PATCH v2 6/7] aarch64,arm: Fix branch-protection= parsing Szabolcs Nagy
2023-12-07 13:02 ` Richard Earnshaw
2023-11-03 15:36 ` [PATCH v2 7/7] aarch64,arm: Move branch-protection data to targets Szabolcs Nagy
2023-12-07 13:13 ` Richard Earnshaw
2024-01-11 14:43 ` Szabolcs Nagy
2024-01-11 14:49 ` Richard Earnshaw (lists)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mpto7fgzpbe.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).