From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id CE6C33858C5E for ; Wed, 14 Jun 2023 19:43:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CE6C33858C5E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D1CA21FB; Wed, 14 Jun 2023 12:44:04 -0700 (PDT) Received: from localhost (e121540-lin.manchester.arm.com [10.32.110.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 087833F5A1; Wed, 14 Jun 2023 12:43:19 -0700 (PDT) From: Richard Sandiford To: Richard Biener Mail-Followup-To: Richard Biener ,Richard Biener via Gcc-patches , richard.sandiford@arm.com Cc: Richard Biener via Gcc-patches Subject: Re: [PATCH 1/3] Inline vect_get_max_nscalars_per_iter References: <20230614114802.BED073858288@sourceware.org> Date: Wed, 14 Jun 2023 20:43:18 +0100 In-Reply-To: (Richard Biener's message of "Wed, 14 Jun 2023 13:46:54 +0000 (UTC)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-27.7 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Richard Biener writes: > On Wed, 14 Jun 2023, Richard Sandiford wrote: > >> Richard Biener via Gcc-patches writes: >> > The function is only meaningful for LOOP_VINFO_MASKS processing so >> > inline it into the single use. >> > >> > Bootstrapped and tested on x86_64-unknown-linux-gnu, OK? >> > >> > * tree-vect-loop.cc (vect_get_max_nscalars_per_iter): Inline >> > into ... >> > (vect_verify_full_masking): ... this. >> >> I think we did have a use for the separate function internally, >> but obviously it was never submitted. Personally I'd prefer >> to keep things as they are though. > > OK - after 3/3 it's no longer "generic" (it wasn't before, > it doesn't inspect the _len groups either), it's only meaningful > for WHILE_ULT style analysis. Ah, yeah, that's fair. Sorry, I hadn't seen the rgc_vec/rgc_map thing when I wrote the above. So yeah, please go ahead. Thanks, Richard > >> >> >> > --- >> > gcc/tree-vect-loop.cc | 22 ++++++---------------- >> > 1 file changed, 6 insertions(+), 16 deletions(-) >> > >> > diff --git a/gcc/tree-vect-loop.cc b/gcc/tree-vect-loop.cc >> > index ace9e759f5b..a9695e5b25d 100644 >> > --- a/gcc/tree-vect-loop.cc >> > +++ b/gcc/tree-vect-loop.cc >> > @@ -1117,20 +1117,6 @@ can_produce_all_loop_masks_p (loop_vec_info loop_vinfo, tree cmp_type) >> > return true; >> > } >> > >> > -/* Calculate the maximum number of scalars per iteration for every >> > - rgroup in LOOP_VINFO. */ >> > - >> > -static unsigned int >> > -vect_get_max_nscalars_per_iter (loop_vec_info loop_vinfo) >> > -{ >> > - unsigned int res = 1; >> > - unsigned int i; >> > - rgroup_controls *rgm; >> > - FOR_EACH_VEC_ELT (LOOP_VINFO_MASKS (loop_vinfo), i, rgm) >> > - res = MAX (res, rgm->max_nscalars_per_iter); >> > - return res; >> > -} >> > - >> > /* Calculate the minimum precision necessary to represent: >> > >> > MAX_NITERS * FACTOR >> > @@ -1210,8 +1196,6 @@ static bool >> > vect_verify_full_masking (loop_vec_info loop_vinfo) >> > { >> > unsigned int min_ni_width; >> > - unsigned int max_nscalars_per_iter >> > - = vect_get_max_nscalars_per_iter (loop_vinfo); >> > >> > /* Use a normal loop if there are no statements that need masking. >> > This only happens in rare degenerate cases: it means that the loop >> > @@ -1219,6 +1203,12 @@ vect_verify_full_masking (loop_vec_info loop_vinfo) >> > if (LOOP_VINFO_MASKS (loop_vinfo).is_empty ()) >> > return false; >> > >> > + /* Calculate the maximum number of scalars per iteration for every rgroup. */ >> > + unsigned int max_nscalars_per_iter = 1; >> > + for (auto rgm : LOOP_VINFO_MASKS (loop_vinfo)) >> > + max_nscalars_per_iter >> > + = MAX (max_nscalars_per_iter, rgm.max_nscalars_per_iter); >> > + >> > /* Work out how many bits we need to represent the limit. */ >> > min_ni_width >> > = vect_min_prec_for_max_niters (loop_vinfo, max_nscalars_per_iter); >>