From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=FN6r=4T=arm.com=richard.sandiford@sourceware.org>
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
	by sourceware.org (Postfix) with ESMTP id EF8C43858D1E
	for <gcc-patches@gcc.gnu.org>; Wed, 21 Dec 2022 09:56:35 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EF8C43858D1E
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 916532F4;
	Wed, 21 Dec 2022 01:57:16 -0800 (PST)
Received: from localhost (e121540-lin.manchester.arm.com [10.32.99.50])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DDA963F71E;
	Wed, 21 Dec 2022 01:56:34 -0800 (PST)
From: Richard Sandiford <richard.sandiford@arm.com>
To: Jakub Jelinek <jakub@redhat.com>
Mail-Followup-To: Jakub Jelinek <jakub@redhat.com>,Richard Earnshaw <richard.earnshaw@arm.com>,  Kyrylo Tkachov <kyrylo.tkachov@arm.com>,  gcc-patches@gcc.gnu.org, richard.sandiford@arm.com
Cc: Richard Earnshaw <richard.earnshaw@arm.com>,  Kyrylo Tkachov <kyrylo.tkachov@arm.com>,  gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] aarch64: Fix plugin header install
References: <Y6GRTuxVgQmxSZT5@tucnak>
Date: Wed, 21 Dec 2022 09:56:33 +0000
In-Reply-To: <Y6GRTuxVgQmxSZT5@tucnak> (Jakub Jelinek's message of "Tue, 20
	Dec 2022 11:41:18 +0100")
Message-ID: <mpto7rx3wry.fsf@arm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-32.3 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

Jakub Jelinek <jakub@redhat.com> writes:
> Hi!
>
> The r13-2943-g11a113d501ff64 made aarch64.h include
> aarch64-option-extensions.def, but that file isn't installed
> for building plugins.
>
> The following patch should fix that, ok for trunk if it
> passes bootstrap/regtest + building plugin against it?
>
> 2022-12-20  Jakub Jelinek  <jakub@redhat.com>
>
> 	* config/aarch64/t-aarch64 (OPTIONS_H_EXTRA): Add
> 	aarch64-option-extensions.def.
>
> --- gcc/config/aarch64/t-aarch64.jj	2022-04-04 13:55:46.001615509 +0200
> +++ gcc/config/aarch64/t-aarch64	2022-12-20 11:31:03.245651809 +0100
> @@ -22,7 +22,8 @@ TM_H += $(srcdir)/config/aarch64/aarch64
>  OPTIONS_H_EXTRA += $(srcdir)/config/aarch64/aarch64-cores.def \
>  		   $(srcdir)/config/aarch64/aarch64-arches.def \
>  		   $(srcdir)/config/aarch64/aarch64-fusion-pairs.def \
> -		   $(srcdir)/config/aarch64/aarch64-tuning-flags.def
> +		   $(srcdir)/config/aarch64/aarch64-tuning-flags.def \
> +		   $(srcdir)/config/aarch64/aarch64-option-extensions.def

Should this (and aarch64-fusion-pairs.def and aarch64-tuning-flags.def)
be in TM_H instead?  The first two OPTIONS_H_EXTRA entries seem to be
for aarch64-opt.h (included via aarch64.opt).

I guess TM_H should also have aarch64-arches.def, since it's included
for aarch64_feature.

OK with that change if it works/makes sense.

Thanks,
Richard

>  
>  $(srcdir)/config/aarch64/aarch64-tune.md: s-aarch64-tune-md; @true
>  s-aarch64-tune-md: $(srcdir)/config/aarch64/gentune.sh \
>
> 	Jakub