From: Richard Sandiford <richard.sandiford@arm.com>
To: Tamar Christina <tamar.christina@arm.com>
Cc: gcc-patches@gcc.gnu.org, nd@arm.com, Richard.Earnshaw@arm.com,
Marcus.Shawcroft@arm.com, Kyrylo.Tkachov@arm.com
Subject: Re: [PATCH 4/8]AArch64 aarch64: Implement widening reduction patterns
Date: Tue, 01 Nov 2022 14:41:58 +0000 [thread overview]
Message-ID: <mpto7tqvirt.fsf@arm.com> (raw)
In-Reply-To: <Y1+4UYIESInTYiGq@arm.com> (Tamar Christina's message of "Mon, 31 Oct 2022 11:58:09 +0000")
Tamar Christina <tamar.christina@arm.com> writes:
> Hi All,
>
> This implements the new widening reduction optab in the backend.
> Instead of introducing a duplicate definition for the same thing I have
> renamed the intrinsics defintions to use the same optab.
>
> Bootstrapped Regtested on aarch64-none-linux-gnu and no issues.
>
> Ok for master?
>
> Thanks,
> Tamar
>
> gcc/ChangeLog:
>
> * config/aarch64/aarch64-simd-builtins.def (saddlv, uaddlv): Rename to
> reduc_splus_widen_scal_ and reduc_uplus_widen_scal_ respectively.
> * config/aarch64/aarch64-simd.md (aarch64_<su>addlv<mode>): Renamed to
> ...
> (reduc_<su>plus_widen_scal_<mode>): ... This.
> * config/aarch64/arm_neon.h (vaddlv_s8, vaddlv_s16, vaddlv_u8,
> vaddlv_u16, vaddlvq_s8, vaddlvq_s16, vaddlvq_s32, vaddlvq_u8,
> vaddlvq_u16, vaddlvq_u32, vaddlv_s32, vaddlv_u32): Use it.
OK, thanks.
Richard
> --- inline copy of patch --
> diff --git a/gcc/config/aarch64/aarch64-simd-builtins.def b/gcc/config/aarch64/aarch64-simd-builtins.def
> index cf46b31627b84476a25762ffc708fd84a4086e43..a4b21e1495c5699d8557a4bcb9e73ef98ae60b35 100644
> --- a/gcc/config/aarch64/aarch64-simd-builtins.def
> +++ b/gcc/config/aarch64/aarch64-simd-builtins.def
> @@ -190,9 +190,9 @@
> BUILTIN_VDQV_L (UNOP, saddlp, 0, NONE)
> BUILTIN_VDQV_L (UNOPU, uaddlp, 0, NONE)
>
> - /* Implemented by aarch64_<su>addlv<mode>. */
> - BUILTIN_VDQV_L (UNOP, saddlv, 0, NONE)
> - BUILTIN_VDQV_L (UNOPU, uaddlv, 0, NONE)
> + /* Implemented by reduc_<su>plus_widen_scal_<mode>. */
> + BUILTIN_VDQV_L (UNOP, reduc_splus_widen_scal_, 10, NONE)
> + BUILTIN_VDQV_L (UNOPU, reduc_uplus_widen_scal_, 10, NONE)
>
> /* Implemented by aarch64_<su>abd<mode>. */
> BUILTIN_VDQ_BHSI (BINOP, sabd, 0, NONE)
> diff --git a/gcc/config/aarch64/aarch64-simd.md b/gcc/config/aarch64/aarch64-simd.md
> index cf8c094bd4b76981cef2dd5dd7b8e6be0d56101f..25aed74f8cf939562ed65a578fe32ca76605b58a 100644
> --- a/gcc/config/aarch64/aarch64-simd.md
> +++ b/gcc/config/aarch64/aarch64-simd.md
> @@ -3455,7 +3455,7 @@ (define_expand "reduc_plus_scal_v4sf"
> DONE;
> })
>
> -(define_insn "aarch64_<su>addlv<mode>"
> +(define_insn "reduc_<su>plus_widen_scal_<mode>"
> [(set (match_operand:<VWIDE_S> 0 "register_operand" "=w")
> (unspec:<VWIDE_S> [(match_operand:VDQV_L 1 "register_operand" "w")]
> USADDLV))]
> diff --git a/gcc/config/aarch64/arm_neon.h b/gcc/config/aarch64/arm_neon.h
> index cf6af728ca99dae1cb6ab647466cfec32f7e913e..7b2c4c016191bcd6c3e075d27810faedb23854b7 100644
> --- a/gcc/config/aarch64/arm_neon.h
> +++ b/gcc/config/aarch64/arm_neon.h
> @@ -3664,70 +3664,70 @@ __extension__ extern __inline int16_t
> __attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
> vaddlv_s8 (int8x8_t __a)
> {
> - return __builtin_aarch64_saddlvv8qi (__a);
> + return __builtin_aarch64_reduc_splus_widen_scal_v8qi (__a);
> }
>
> __extension__ extern __inline int32_t
> __attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
> vaddlv_s16 (int16x4_t __a)
> {
> - return __builtin_aarch64_saddlvv4hi (__a);
> + return __builtin_aarch64_reduc_splus_widen_scal_v4hi (__a);
> }
>
> __extension__ extern __inline uint16_t
> __attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
> vaddlv_u8 (uint8x8_t __a)
> {
> - return __builtin_aarch64_uaddlvv8qi_uu (__a);
> + return __builtin_aarch64_reduc_uplus_widen_scal_v8qi_uu (__a);
> }
>
> __extension__ extern __inline uint32_t
> __attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
> vaddlv_u16 (uint16x4_t __a)
> {
> - return __builtin_aarch64_uaddlvv4hi_uu (__a);
> + return __builtin_aarch64_reduc_uplus_widen_scal_v4hi_uu (__a);
> }
>
> __extension__ extern __inline int16_t
> __attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
> vaddlvq_s8 (int8x16_t __a)
> {
> - return __builtin_aarch64_saddlvv16qi (__a);
> + return __builtin_aarch64_reduc_splus_widen_scal_v16qi (__a);
> }
>
> __extension__ extern __inline int32_t
> __attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
> vaddlvq_s16 (int16x8_t __a)
> {
> - return __builtin_aarch64_saddlvv8hi (__a);
> + return __builtin_aarch64_reduc_splus_widen_scal_v8hi (__a);
> }
>
> __extension__ extern __inline int64_t
> __attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
> vaddlvq_s32 (int32x4_t __a)
> {
> - return __builtin_aarch64_saddlvv4si (__a);
> + return __builtin_aarch64_reduc_splus_widen_scal_v4si (__a);
> }
>
> __extension__ extern __inline uint16_t
> __attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
> vaddlvq_u8 (uint8x16_t __a)
> {
> - return __builtin_aarch64_uaddlvv16qi_uu (__a);
> + return __builtin_aarch64_reduc_uplus_widen_scal_v16qi_uu (__a);
> }
>
> __extension__ extern __inline uint32_t
> __attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
> vaddlvq_u16 (uint16x8_t __a)
> {
> - return __builtin_aarch64_uaddlvv8hi_uu (__a);
> + return __builtin_aarch64_reduc_uplus_widen_scal_v8hi_uu (__a);
> }
>
> __extension__ extern __inline uint64_t
> __attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
> vaddlvq_u32 (uint32x4_t __a)
> {
> - return __builtin_aarch64_uaddlvv4si_uu (__a);
> + return __builtin_aarch64_reduc_uplus_widen_scal_v4si_uu (__a);
> }
>
> __extension__ extern __inline float32x2_t
> @@ -6461,14 +6461,14 @@ __extension__ extern __inline int64_t
> __attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
> vaddlv_s32 (int32x2_t __a)
> {
> - return __builtin_aarch64_saddlvv2si (__a);
> + return __builtin_aarch64_reduc_splus_widen_scal_v2si (__a);
> }
>
> __extension__ extern __inline uint64_t
> __attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
> vaddlv_u32 (uint32x2_t __a)
> {
> - return __builtin_aarch64_uaddlvv2si_uu (__a);
> + return __builtin_aarch64_reduc_uplus_widen_scal_v2si_uu (__a);
> }
>
> __extension__ extern __inline int16x4_t
next prev parent reply other threads:[~2022-11-01 14:42 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 11:56 [PATCH 1/8]middle-end: Recognize scalar reductions from bitfields and array_refs Tamar Christina
2022-10-31 11:57 ` [PATCH 2/8]middle-end: Recognize scalar widening reductions Tamar Christina
2022-10-31 21:42 ` Jeff Law
2022-11-07 13:21 ` Richard Biener
2022-10-31 11:57 ` [PATCH 3/8]middle-end: Support extractions of subvectors from arbitrary element position inside a vector Tamar Christina
2022-10-31 21:44 ` Jeff Law
2022-11-01 14:25 ` Richard Sandiford
2022-11-11 14:33 ` Tamar Christina
2022-11-15 8:35 ` Hongtao Liu
2022-11-15 8:51 ` Tamar Christina
2022-11-15 9:37 ` Hongtao Liu
2022-11-15 10:00 ` Tamar Christina
2022-11-15 17:39 ` Richard Sandiford
2022-11-17 8:04 ` Hongtao Liu
2022-11-17 9:39 ` Richard Sandiford
2022-11-17 10:20 ` Hongtao Liu
2022-11-17 13:59 ` Richard Sandiford
2022-11-18 2:31 ` Hongtao Liu
2022-11-18 9:16 ` Richard Sandiford
2022-10-31 11:58 ` [PATCH 4/8]AArch64 aarch64: Implement widening reduction patterns Tamar Christina
2022-11-01 14:41 ` Richard Sandiford [this message]
2022-10-31 11:58 ` [PATCH 5/8]AArch64 aarch64: Make existing V2HF be usable Tamar Christina
2022-11-01 14:58 ` Richard Sandiford
2022-11-01 15:11 ` Tamar Christina
2022-11-11 14:39 ` Tamar Christina
2022-11-22 16:01 ` Tamar Christina
2022-11-30 4:26 ` Tamar Christina
2022-12-06 10:28 ` Richard Sandiford
2022-12-06 10:58 ` Tamar Christina
2022-12-06 11:05 ` Richard Sandiford
2022-10-31 11:59 ` [PATCH 6/8]AArch64: Add peephole and scheduling logic for pairwise operations that appear late in RTL Tamar Christina
2022-10-31 11:59 ` [PATCH 7/8]AArch64: Consolidate zero and sign extension patterns and add missing ones Tamar Christina
2022-11-30 4:28 ` Tamar Christina
2022-12-06 15:59 ` Richard Sandiford
2022-10-31 12:00 ` [PATCH 8/8]AArch64: Have reload not choose to do add on the scalar side if both values exist on the SIMD side Tamar Christina
2022-11-01 15:04 ` Richard Sandiford
2022-11-01 15:20 ` Tamar Christina
2022-10-31 21:41 ` [PATCH 1/8]middle-end: Recognize scalar reductions from bitfields and array_refs Jeff Law
2022-11-05 11:32 ` Richard Biener
2022-11-07 7:16 ` Tamar Christina
2022-11-07 10:17 ` Richard Biener
2022-11-07 11:00 ` Tamar Christina
2022-11-07 11:22 ` Richard Biener
2022-11-07 11:56 ` Tamar Christina
2022-11-22 10:36 ` Richard Sandiford
2022-11-22 10:58 ` Richard Biener
2022-11-22 11:02 ` Tamar Christina
2022-11-22 11:06 ` Richard Sandiford
2022-11-22 11:08 ` Richard Biener
2022-11-22 14:33 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mpto7tqvirt.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=Kyrylo.Tkachov@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
--cc=tamar.christina@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).