From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 24B933858C39 for ; Tue, 20 Sep 2022 08:33:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 24B933858C39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 42F57169C; Tue, 20 Sep 2022 01:33:35 -0700 (PDT) Received: from localhost (e121540-lin.manchester.arm.com [10.32.98.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4547D3F73B; Tue, 20 Sep 2022 01:33:28 -0700 (PDT) From: Richard Sandiford To: Jojo R via Gcc-patches Mail-Followup-To: Jojo R via Gcc-patches ,rjiejie@linux.alibaba.com, richard.sandiford@arm.com Cc: rjiejie@linux.alibaba.com Subject: Re: [PATCH] genrecog.cc (print_nonbool_test): Fix type error of SUBREG_BYTE References: <20220919060141.5014-1-rjiejie@linux.alibaba.com> Date: Tue, 20 Sep 2022 09:33:27 +0100 In-Reply-To: <20220919060141.5014-1-rjiejie@linux.alibaba.com> (Jojo R. via Gcc-patches's message of "Mon, 19 Sep 2022 14:01:41 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-47.8 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Jojo R via Gcc-patches writes: > * gcc/genrecog.cc (print_nonbool_test): Fix type error of > SUBREG_BYTE We can't do this here. The code has done nothing to prove that the subreg offset is a compile-time constant. Thanks, Richard > --- > gcc/genrecog.cc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gcc/genrecog.cc b/gcc/genrecog.cc > index 77f8fb97853..319e437e334 100644 > --- a/gcc/genrecog.cc > +++ b/gcc/genrecog.cc > @@ -4619,6 +4619,7 @@ print_nonbool_test (output_state *os, const rtx_test &test) > printf ("SUBREG_BYTE ("); > print_test_rtx (os, test); > printf (")"); > + printf (".to_constant ()"); > break; > > case rtx_test::WIDE_INT_FIELD: