From: Richard Sandiford <richard.sandiford@arm.com>
To: Mariam Arutunian <mariamarutunian@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [RFC/RFA][PATCH v3 06/12] aarch64: Implement new expander for efficient CRC computation
Date: Fri, 09 Aug 2024 19:00:48 +0100 [thread overview]
Message-ID: <mptr0axvanj.fsf@arm.com> (raw)
In-Reply-To: <mptjzgpwwkd.fsf@arm.com> (Richard Sandiford's message of "Fri, 09 Aug 2024 16:22:10 +0100")
Richard Sandiford <richard.sandiford@arm.com> writes:
> [...]
> /* Perform a shift right by CRC_SIZE as an extraction of lane 1. */
> machine_mode crc_vmode = aarch64_vq_mode (crc_mode).require ();
> a0 = (crc_size > data_size ? gen_reg_rtx (crc_mode) : operands[0]);
> emit_insn (gen_aarch64_get_lane (crc_vmode, a0,
> gen_lowpart (crc_vmode, clmul_res),
> aarch64_endian_lane_rtx (crc_vmode, 1)));
Sorry, I forgot to say that I'd locally patched:
diff --git a/gcc/config/aarch64/aarch64-simd.md b/gcc/config/aarch64/aarch64-simd.md
index 816f499e963..af7beecb735 100644
--- a/gcc/config/aarch64/aarch64-simd.md
+++ b/gcc/config/aarch64/aarch64-simd.md
@@ -4301,7 +4301,7 @@ (define_insn "*aarch64_get_lane_zero_extend<GPI:mode><VDQQH:mode>"
;; RTL uses GCC vector extension indices throughout so flip only for assembly.
;; Extracting lane zero is split into a simple move when it is between SIMD
;; registers or a store.
-(define_insn_and_split "aarch64_get_lane<mode>"
+(define_insn_and_split "@aarch64_get_lane<mode>"
[(set (match_operand:<VEL> 0 "aarch64_simd_nonimmediate_operand" "=?r, w, Utv")
(vec_select:<VEL>
(match_operand:VALL_F16 1 "register_operand" "w, w, w")
Richard
next prev parent reply other threads:[~2024-08-09 18:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 18:07 Mariam Arutunian
2024-08-09 15:22 ` Richard Sandiford
2024-08-09 18:00 ` Richard Sandiford [this message]
2024-08-16 15:25 ` Mariam Arutunian
2024-08-20 12:22 ` Mariam Arutunian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mptr0axvanj.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mariamarutunian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).