From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 616693858D37 for ; Wed, 24 Jan 2024 09:30:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 616693858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 616693858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706088658; cv=none; b=M/UnwZ+a2xZSts7fJkmgxFfeZ3U562dP1ppVKodD3qjPqqzrJi7mORBMke81fiM4mbMBAisAZoydFJXW8AqhyknufxbAfaha0T+e9cEtHhxx29quMr9ddM5XJjz79bNhgDI/rDYyjHNSio4GPw+9Fteq1s99D93uGqwo73TFKfw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706088658; c=relaxed/simple; bh=zFNI8n1Clbf4Wy1nia8VpIyLxyz+/CG2/xNSAtBEFlo=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=P4/JyBb1JTDA7b+leJAgo2mvQ5p7d+XJFj6xKaXs1gCZIeaqB0dnzoq6x6x+3LPCLPBo2KK73Et4lyKkMGvuF2cRcU564sPAhCxNUngMioViyjRav+QdWTWzZ8GvtFLHDlyLaixKBz11TnGfo8UKWuzIFaiI1GhzgGejPIS4ifQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9086D1FB; Wed, 24 Jan 2024 01:31:35 -0800 (PST) Received: from localhost (e121540-lin.manchester.arm.com [10.32.110.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9426E3F762; Wed, 24 Jan 2024 01:30:49 -0800 (PST) From: Richard Sandiford To: Tamar Christina Mail-Followup-To: Tamar Christina ,gcc-patches@gcc.gnu.org, nd@arm.com, Richard.Earnshaw@arm.com, Marcus.Shawcroft@arm.com, Kyrylo.Tkachov@arm.com, richard.sandiford@arm.com Cc: gcc-patches@gcc.gnu.org, nd@arm.com, Richard.Earnshaw@arm.com, Marcus.Shawcroft@arm.com, Kyrylo.Tkachov@arm.com Subject: Re: [PATCH]AArch64: Do not allow SIMD clones with simdlen 1 [PR113552] References: Date: Wed, 24 Jan 2024 09:30:48 +0000 In-Reply-To: (Tamar Christina's message of "Wed, 24 Jan 2024 09:20:16 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-21.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_LOTSOFHASH,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tamar Christina writes: > Hi All, > > The AArch64 vector PCS does not allow simd calls with simdlen 1, > however due to a bug we currently do allow it for num == 0. > > This causes us to emit a symbol that doesn't exist and we fail to link. > > Bootstrapped Regtested on aarch64-none-linux-gnu and no issues. > > Ok for master? and for backport to GCC 13,12,11? > > Thanks, > Tamar > > > > gcc/ChangeLog: > > PR tree-optimization/113552 > * config/aarch64/aarch64.cc > (aarch64_simd_clone_compute_vecsize_and_simdlen): Block simdlen 1. > > gcc/testsuite/ChangeLog: > > PR tree-optimization/113552 > * gcc.target/aarch64/pr113552.c: New test. > * gcc.target/aarch64/simd_pcs_attribute-3.c: Remove bogus check. > > --- inline copy of patch -- > diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc > index e6bd3fd0bb42c70603d5335402b89c9deeaf48d8..a2fc1a5d9d27e9d837e4d616e3feaf38f7272b4f 100644 > --- a/gcc/config/aarch64/aarch64.cc > +++ b/gcc/config/aarch64/aarch64.cc > @@ -28620,7 +28620,8 @@ aarch64_simd_clone_compute_vecsize_and_simdlen (struct cgraph_node *node, > if (known_eq (clonei->simdlen, 0U)) > { > simdlen = exact_div (poly_uint64 (64), nds_elt_bits); > - simdlens.safe_push (simdlen); > + if (known_ne (simdlen, 1U)) maybe_ne (i.e. !known_eq) is more canonical. > + simdlens.safe_push (simdlen); > simdlens.safe_push (simdlen * 2); > } > else > diff --git a/gcc/testsuite/gcc.target/aarch64/pr113552.c b/gcc/testsuite/gcc.target/aarch64/pr113552.c > new file mode 100644 > index 0000000000000000000000000000000000000000..9c96b061ed2b4fcc57e58925277f74d14f79c51f > --- /dev/null > +++ b/gcc/testsuite/gcc.target/aarch64/pr113552.c > @@ -0,0 +1,17 @@ > +/* { dg-do compile } */ > +/* { dg-options "-Ofast -march=armv8-a" } */ > + > +__attribute__ ((__simd__ ("notinbranch"), const)) > +double cos (double); > + > +void foo (float *a, double *b) > +{ > + for (int i = 0; i < 12; i+=3) > + { > + b[i] = cos (5.0 * a[i]); > + b[i+1] = cos (5.0 * a[i+1]); > + b[i+2] = cos (5.0 * a[i+2]); > + } > +} > + > +/* { dg-final { scan-assembler-times {bl\t_ZGVnN2v_cos} 6 } } */ > diff --git a/gcc/testsuite/gcc.target/aarch64/simd_pcs_attribute-3.c b/gcc/testsuite/gcc.target/aarch64/simd_pcs_attribute-3.c > index 95f6a6803e889c02177ef10972962ed62d2095eb..661764b3d4a89e08951a7a3c0495d5b7ba7f0871 100644 > --- a/gcc/testsuite/gcc.target/aarch64/simd_pcs_attribute-3.c > +++ b/gcc/testsuite/gcc.target/aarch64/simd_pcs_attribute-3.c > @@ -18,7 +18,5 @@ double foo(double x) > } > > /* { dg-final { scan-assembler-not {\.variant_pcs\tfoo} } } */ > -/* { dg-final { scan-assembler-times {\.variant_pcs\t_ZGVnM1v_foo} 1 } } */ > /* { dg-final { scan-assembler-times {\.variant_pcs\t_ZGVnM2v_foo} 1 } } */ > -/* { dg-final { scan-assembler-times {\.variant_pcs\t_ZGVnN1v_foo} 1 } } */ > /* { dg-final { scan-assembler-times {\.variant_pcs\t_ZGVnN2v_foo} 1 } } */ Think it'd be a bit safer to turn these into scan-assembler-nots, rather than remove them. OK for trunk and branches with those changes, thanks. Richard