From: Richard Sandiford <richard.sandiford@arm.com>
To: gcc-patches@gcc.gnu.org
Subject: [pushed] read-rtl: Fix infinite loop while parsing [...]
Date: Sun, 05 Nov 2023 18:27:03 +0000 [thread overview]
Message-ID: <mptr0l49hu0.fsf@arm.com> (raw)
read_rtx_operand would spin endlessly for:
(unspec [(...))] UNSPEC_FOO)
because read_nested_rtx does nothing if the next character is not '('.
Pushed after testing on aarch64-linux-gnu & x86_&4-linux-gnu.
Richard
gcc/
* read-rtl.cc (read_rtx_operand): Avoid spinning endlessly for
invalid [...] operands.
---
gcc/read-rtl.cc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/gcc/read-rtl.cc b/gcc/read-rtl.cc
index 292f8b72d43..f3b5613dfdb 100644
--- a/gcc/read-rtl.cc
+++ b/gcc/read-rtl.cc
@@ -1896,8 +1896,10 @@ rtx_reader::read_rtx_operand (rtx return_rtx, int idx)
repeat_count--;
value = saved_rtx;
}
- else
+ else if (c == '(')
value = read_nested_rtx ();
+ else
+ fatal_with_file_and_line ("unexpected character in vector");
for (; repeat_count > 0; repeat_count--)
{
--
2.25.1
reply other threads:[~2023-11-05 18:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mptr0l49hu0.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).