From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id EF1493858CDB for ; Sun, 5 Nov 2023 18:27:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EF1493858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EF1493858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699208844; cv=none; b=CIHGFIPw+hALSTlZ47n0dTkGk0bUdfGX0CVm5ChAE/aHrdqy+LxVcR0h6U4cGPt2QD9OJ7aVID1V2leERoplbyYeCDR/BUurOgR8XeiJPsjzKjoNJcSxWjQQpviyy8nsEb8+7NyhSsn9eTdNfFQaVISQdij5vBYEhvix16vL70o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699208844; c=relaxed/simple; bh=fcROdLfjjeM6d1DfZf4YpI21H+sTut01YLASHGlBUvo=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=YlSnlZARjMz6oFNW5KbK3W6o39w2V9vkchlgw+q0Uc7B0hg7PG+kFIF75WOONy7r4xdZ/Fnb6G8Ew5J+89Rdxkc6NDZ1hbkPhMFEqtgKnJPivBSiTDCmwN0Ojpao99PViQkSbgN6SYpYyLlUHrIW8vmc1NKZTwqQyDT717xXMzM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 48328C15 for ; Sun, 5 Nov 2023 10:28:04 -0800 (PST) Received: from localhost (e121540-lin.manchester.arm.com [10.32.110.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1CD8C3F703 for ; Sun, 5 Nov 2023 10:27:20 -0800 (PST) From: Richard Sandiford To: gcc-patches@gcc.gnu.org Mail-Followup-To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com Subject: [pushed] read-rtl: Fix infinite loop while parsing [...] Date: Sun, 05 Nov 2023 18:27:03 +0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-23.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: read_rtx_operand would spin endlessly for: (unspec [(...))] UNSPEC_FOO) because read_nested_rtx does nothing if the next character is not '('. Pushed after testing on aarch64-linux-gnu & x86_&4-linux-gnu. Richard gcc/ * read-rtl.cc (read_rtx_operand): Avoid spinning endlessly for invalid [...] operands. --- gcc/read-rtl.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gcc/read-rtl.cc b/gcc/read-rtl.cc index 292f8b72d43..f3b5613dfdb 100644 --- a/gcc/read-rtl.cc +++ b/gcc/read-rtl.cc @@ -1896,8 +1896,10 @@ rtx_reader::read_rtx_operand (rtx return_rtx, int idx) repeat_count--; value = saved_rtx; } - else + else if (c == '(') value = read_nested_rtx (); + else + fatal_with_file_and_line ("unexpected character in vector"); for (; repeat_count > 0; repeat_count--) { -- 2.25.1