From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 3B3C73858C41 for ; Thu, 26 Oct 2023 19:40:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3B3C73858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3B3C73858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698349220; cv=none; b=FLCj7FBFngrZoQ0Hj6XS5bo3n/1ABZrZeTPv5RR+bEDPxyLrNzT9DdRnOSvB5JuC5zb6KYpdS1GSZ1Mw17EsnnvNZUuTaLyzJe3gxRonSl1d7MgY9ATf5yhDQ/dJHHzJkwTAPuMqSj0RXT/71ipOBqLdH99//lagDa3Dpzb/LL8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698349220; c=relaxed/simple; bh=nCtA72QyXXbrZG2MHmujObWMqsX/omyedaQV6YNL+OA=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=X7ZnMFm0qyH6okzNNBNjrwW8mafECnafOxvEycYktPlkAPSTRrclOD+RLwQ+6lUI35/1Oxlvk52TIxOlnqoXkNqmcI2n5ijw8kdAVDfAHK0L1JyXAlaTRrcBIFdIQvfAPbxE34jEFZdWs0pA7sEJTlwNz0B0KFh/ibMTmw34lYc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 614B61424; Thu, 26 Oct 2023 12:41:00 -0700 (PDT) Received: from localhost (e121540-lin.manchester.arm.com [10.32.110.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3F4BE3F738; Thu, 26 Oct 2023 12:40:18 -0700 (PDT) From: Richard Sandiford To: Iain Sandoe Mail-Followup-To: Iain Sandoe ,gcc-patches@gcc.gnu.org, iain@sandoe.co.uk, richard.sandiford@arm.com Cc: gcc-patches@gcc.gnu.org, iain@sandoe.co.uk Subject: Re: [PATCH] testsuite, aarch64: Normalise options to aarch64.exp. References: <20231026185734.56102-1-iain@sandoe.co.uk> Date: Thu, 26 Oct 2023 20:40:17 +0100 In-Reply-To: <20231026185734.56102-1-iain@sandoe.co.uk> (Iain Sandoe's message of "Thu, 26 Oct 2023 19:57:34 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-23.5 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Iain Sandoe writes: > tested on cfarm185 (aarch64-linux-gnu, xgene1) and with the aarch64 > Darwin prototype. It is possible that some initial fallout could occur > on some test setups (where the default has been catered for in some > way) - but that should stabilize. OK for trunk? > thanks > Iain > > --- 8< --- > > When the compiler is configured --with-cpu= and that is different from > the baselines assumed, we see excess test fails (primarly in body code > scans which are necessarily sensitive to costs). To stabilize the > testsuite against such changes, use aarch64-with-arch-dg-options () > to provide suitable consistent defaults. > > e.g. for --with-cpu=xgene1 we see over 100 excess fails which are > removed by this change. > > gcc/testsuite/ChangeLog: > > * gcc.target/aarch64/aarch64.exp: Use aarch64-with-arch-dg-options > to normaize the options to the tests in aarch64.exp. OK, thanks. I also tried it on two local set-ups and it passed on both. Richard > > Signed-off-by: Iain Sandoe > --- > gcc/testsuite/gcc.target/aarch64/aarch64.exp | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/gcc/testsuite/gcc.target/aarch64/aarch64.exp b/gcc/testsuite/gcc.target/aarch64/aarch64.exp > index bd306e3b288..7612ea704e5 100644 > --- a/gcc/testsuite/gcc.target/aarch64/aarch64.exp > +++ b/gcc/testsuite/gcc.target/aarch64/aarch64.exp > @@ -37,9 +37,10 @@ if ![info exists DEFAULT_CFLAGS] then { > # Initialize `dg'. > dg-init > > -# Main loop. > -dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cCS\]]] \ > - "" $DEFAULT_CFLAGS > - > +aarch64-with-arch-dg-options "" { > + # Main loop. > + dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cCS\]]] \ > + "" $DEFAULT_CFLAGS > +} > # All done. > dg-finish