public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Sandiford <richard.sandiford@arm.com>
To: Xi Ruoyao <xry111@mengyan1223.wang>
Cc: Qing Zhao <qing.zhao@oracle.com>, Jeff Law <law@redhat.com>,
	"gcc-patches\@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	YunQiang Su <yunqiang.su@cipunited.com>,
	Jakub Jelinek <jakub@gcc.gnu.org>
Subject: Re: [PATCH RFC] mips: add TARGET_ZERO_CALL_USED_REGS hook [PR104817, PR104820]
Date: Fri, 18 Mar 2022 16:09:30 +0000	[thread overview]
Message-ID: <mptr16z44zp.fsf@arm.com> (raw)
In-Reply-To: <c3a19e2fa7341acc23e7c57bce04fe5e1b93467e.camel@mengyan1223.wang> (Xi Ruoyao's message of "Fri, 18 Mar 2022 21:11:06 +0800")

Xi Ruoyao <xry111@mengyan1223.wang> writes:
>> 
>> If we have to go this way, I think it’s better to make the change you
>> suggested above, 
>> and then also update the documentation, both internal documentation on
>> how to define
>>  the hook and the user level documentation on what the user might
>> expect when using 
>> this option (i.e, it’s possible that the compiler might clear more
>> registers than the user 
>> requests on some targets due to the implementation limitation). 
>> 
>> I can make this change if we decide to do this.
>
> I'd vote for this.  Richard?

Fine by me too, although I don't think this should be mentioned
in the user documentation.  E.g. used-arg means that non-argument,
non-return registers can have any value on return from the function;
the compiler doesn't make any guarantees.  If the compiler happens to
use a temporary register in the implementation of the option, and if
that temporary register happens to still be zero on return, then
that's OK.  It's just an internal implementation detail.  The same
thing could happen for any part of the epilogue.

Thanks,
Richard

  reply	other threads:[~2022-03-18 16:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-07 20:40 Xi Ruoyao
2022-03-09 18:25 ` Richard Sandiford
2022-03-10 11:53   ` Xi Ruoyao
2022-03-10 13:41     ` [PATCH v2 " Xi Ruoyao
2022-03-10 13:45       ` [PATCH v2 RFC, resend] " Xi Ruoyao
2022-03-10 20:31   ` [PATCH RFC] " Qing Zhao
2022-03-11  2:54     ` Xi Ruoyao
2022-03-11 16:08       ` Qing Zhao
2022-03-11 17:29         ` Xi Ruoyao
2022-03-11 17:31           ` Xi Ruoyao
2022-03-11 21:26           ` Qing Zhao
2022-03-12 10:48             ` Xi Ruoyao
2022-03-13  6:03               ` Xi Ruoyao
2022-03-14 16:04                 ` Richard Sandiford
2022-03-14 17:05                   ` Xi Ruoyao
2022-03-16 20:27                   ` Qing Zhao
2022-03-18 13:11                     ` Xi Ruoyao
2022-03-18 16:09                       ` Richard Sandiford [this message]
2022-03-18 18:51                         ` Qing Zhao
2022-04-01 14:32           ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mptr16z44zp.fsf@arm.com \
    --to=richard.sandiford@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@gcc.gnu.org \
    --cc=law@redhat.com \
    --cc=qing.zhao@oracle.com \
    --cc=xry111@mengyan1223.wang \
    --cc=yunqiang.su@cipunited.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).