From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15503 invoked by alias); 11 Sep 2019 19:14:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 15492 invoked by uid 89); 11 Sep 2019 19:14:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.110.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Sep 2019 19:14:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8B24B1000 for ; Wed, 11 Sep 2019 12:14:55 -0700 (PDT) Received: from localhost (e121540-lin.manchester.arm.com [10.32.99.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3397B3F59C for ; Wed, 11 Sep 2019 12:14:55 -0700 (PDT) From: Richard Sandiford To: gcc-patches@gcc.gnu.org Mail-Followup-To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com Subject: [23/32] Remove global call sets: postreload-gcse.c References: Date: Wed, 11 Sep 2019 19:14:00 -0000 In-Reply-To: (Richard Sandiford's message of "Wed, 11 Sep 2019 20:02:26 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00804.txt.bz2 This is another case in which we should conservatively treat partial kills as full kills. 2019-09-11 Richard Sandiford gcc/ * postreload-gcse.c: Include regs.h and function-abi.h. (record_opr_changes): Use call_insn_abi to get the ABI of the call insn target. Conservatively assume that partially-clobbered registers are altered. Index: gcc/postreload-gcse.c =================================================================== --- gcc/postreload-gcse.c 2019-09-09 18:58:51.472270712 +0100 +++ gcc/postreload-gcse.c 2019-09-11 19:48:45.585690715 +0100 @@ -41,6 +41,8 @@ Software Foundation; either version 3, o #include "intl.h" #include "gcse-common.h" #include "gcse.h" +#include "regs.h" +#include "function-abi.h" /* The following code implements gcse after reload, the purpose of this pass is to cleanup redundant loads generated by reload and other @@ -770,9 +772,13 @@ record_opr_changes (rtx_insn *insn) /* Finally, if this is a call, record all call clobbers. */ if (CALL_P (insn)) { + function_abi abi = call_insn_abi (insn); unsigned int regno; hard_reg_set_iterator hrsi; - EXECUTE_IF_SET_IN_HARD_REG_SET (regs_invalidated_by_call, 0, regno, hrsi) + /* We don't track modes of hard registers, so we need to be + conservative and assume that partial kills are full kills. */ + EXECUTE_IF_SET_IN_HARD_REG_SET (abi.full_and_partial_reg_clobbers (), + 0, regno, hrsi) record_last_reg_set_info_regno (insn, regno); if (! RTL_CONST_OR_PURE_CALL_P (insn))