From: Richard Sandiford <richard.sandiford@arm.com>
To: "juzhe.zhong\@rivai.ai" <juzhe.zhong@rivai.ai>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, rguenther <rguenther@suse.de>
Subject: Re: [PATCH V4] VECT: Add decrement IV iteration loop control by variable amount support
Date: Thu, 11 May 2023 12:29:18 +0100 [thread overview]
Message-ID: <mptsfc3f6nl.fsf@arm.com> (raw)
In-Reply-To: <F90DA350877E65B8+20230511192103155035231@rivai.ai> (juzhe's message of "Thu, 11 May 2023 19:21:04 +0800")
"juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai> writes:
> Oh, I see. But I saw there is a variable using_partial_vectors_p
> in the loop data structure.
>
> Can I add a variable call using_select_vl_p ?
Yeah. Please also add a wrapper macro like
LOOP_VINFO_USING_PARTIAL_VECTORS_P. (I'm not really a fan of the
wrappers, but it's better to be consistent.)
> Since it may increase the size of data structure, I am not sure whether it is appropriate.
The structure is only temporary, and very few of them exist at
a given time. Besides, there's already a layout hole on LP64 hosts
around those booleans (between slp_unrolling_factor and scalar_loop).
So the new boolean shouldn't grow the size of the structure.
We can convert the booleans to bitfields if size ever becomes a problem.
Thanks,
Richard
next prev parent reply other threads:[~2023-05-11 11:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 13:25 juzhe.zhong
2023-05-05 23:41 ` 钟居哲
2023-05-09 12:59 ` Richard Sandiford
2023-05-09 13:27 ` juzhe.zhong
2023-05-09 14:34 ` 钟居哲
2023-05-07 15:19 ` Jeff Law
2023-05-07 21:54 ` 钟居哲
2023-05-09 10:52 ` juzhe.zhong
2023-05-08 5:35 ` Kewen.Lin
2023-05-08 6:27 ` juzhe.zhong
2023-05-08 7:55 ` Kewen.Lin
2023-05-08 8:25 ` juzhe.zhong
2023-05-10 16:45 ` Richard Sandiford
2023-05-10 21:00 ` 钟居哲
2023-05-10 21:28 ` Richard Sandiford
2023-05-10 22:51 ` 钟居哲
2023-05-11 4:50 ` Richard Sandiford
2023-05-11 5:14 ` juzhe.zhong
2023-05-11 10:11 ` juzhe.zhong
2023-05-11 11:04 ` Richard Sandiford
2023-05-11 11:21 ` juzhe.zhong
2023-05-11 11:29 ` Richard Sandiford [this message]
2023-05-11 12:08 ` juzhe.zhong
2023-05-11 12:42 ` Richard Sandiford
2023-05-11 23:12 ` 钟居哲
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mptsfc3f6nl.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).