From: Richard Sandiford <richard.sandiford@arm.com>
To: Lulu Cheng <chenglulu@loongson.cn>
Cc: gcc-patches@gcc.gnu.org, xry111@xry111.site, i@xen0n.name,
xuchenghua@loongson.cn
Subject: Re: [PATCH] doc: Correct a clerical error in the document.
Date: Wed, 07 Dec 2022 10:05:59 +0000 [thread overview]
Message-ID: <mptsfhr8r5k.fsf@arm.com> (raw)
In-Reply-To: <20221207014152.3313833-1-chenglulu@loongson.cn> (Lulu Cheng's message of "Wed, 7 Dec 2022 09:41:53 +0800")
Lulu Cheng <chenglulu@loongson.cn> writes:
> gcc/ChangeLog:
>
> * doc/rtl.texi: Correct a clerical error in the document.
> ---
> gcc/doc/rtl.texi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/doc/rtl.texi b/gcc/doc/rtl.texi
> index 43c9ee8bffe..44858d12892 100644
> --- a/gcc/doc/rtl.texi
> +++ b/gcc/doc/rtl.texi
> @@ -2142,7 +2142,7 @@ stores the lower 2 bytes of @var{y} in @var{x} and discards the upper
> (set @var{z} (subreg:SI (reg:HI @var{x}) 0))
> @end smallexample
>
> -would set the lower two bytes of @var{z} to @var{y} and set the upper
> +would set the lower two bytes of @var{z} to @var{x} and set the upper
> two bytes to an unknown value assuming @code{SUBREG_PROMOTED_VAR_P} is
> false.
Both versions are right in their way. I think the intention of the
original was to show the effect of moving y to z via a paradoxical
subreg on x.
How about:
would set the lower two bytes of @var{z} to @var{x} (which contains
the lower two bytes of @var{y}) and set the upper ...
OK with that change if you agree.
Richard
next prev parent reply other threads:[~2022-12-07 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 1:41 Lulu Cheng
2022-12-07 10:05 ` Richard Sandiford [this message]
2022-12-08 1:15 ` Lulu Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mptsfhr8r5k.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=chenglulu@loongson.cn \
--cc=gcc-patches@gcc.gnu.org \
--cc=i@xen0n.name \
--cc=xry111@xry111.site \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).