public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Sandiford <richard.sandiford@arm.com>
To: xuchenghua@loongson.cn
Cc: gcc-patches@gcc.gnu.org,  chenglulu@loongson.cn,
	 joseph@codesourcery.com
Subject: Re: [PATCH v8 11/12] LoongArch Port: gcc/testsuite
Date: Tue, 08 Mar 2022 19:06:02 +0000	[thread overview]
Message-ID: <mptsfrsgt7p.fsf@arm.com> (raw)
In-Reply-To: <20220304071809.3082015-12-xuchenghua@loongson.cn> (xuchenghua@loongson.cn's message of "Fri, 4 Mar 2022 15:18:08 +0800")

xuchenghua@loongson.cn writes:
> diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
> index 737e1a8913b..843b508b010 100644
> --- a/gcc/testsuite/lib/target-supports.exp
> +++ b/gcc/testsuite/lib/target-supports.exp
> @@ -286,6 +286,10 @@ proc check_configured_with { pattern } {
>  proc check_weak_available { } {
>      global target_cpu
>  
> +    if { [ string first "loongarch" $target_cpu ] >= 0 } {
> +        return 1
> +    }
> +
>      # All mips targets should support it
>  
>      if { [ string first "mips" $target_cpu ] >= 0 } {

For modern targets, the procedure ought to give the right answer without
this change.  I'm not sure off-hand which MIPS target required the
special case, but it's probably not one we support any more.

It would be good to have tests in gcc.target/loongarch that cover
all of the intrinsics defined in larchintrin.h.

Looks good to me otherwise, thanks.

Richard

  reply	other threads:[~2022-03-08 19:06 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-04  7:17 [PATCH v8 00/12] Add LoongArch support xuchenghua
2022-03-04  7:17 ` [PATCH v8 01/12] LoongArch Port: Regenerate configure xuchenghua
2022-03-04  7:17 ` [PATCH v8 02/12] LoongArch Port: gcc build xuchenghua
2022-03-06 10:29   ` Richard Sandiford
2022-03-06 10:34     ` Andreas Schwab
2022-03-04  7:18 ` [PATCH v8 03/12] LoongArch Port: Regenerate gcc/configure xuchenghua
2022-03-04  7:18 ` [PATCH v8 04/12] LoongArch Port: Machine description files xuchenghua
2022-03-06 16:16   ` Richard Sandiford
2022-03-07  3:59     ` 程璐璐
2022-03-19  9:40     ` 程璐璐
2022-03-07 20:15   ` Xi Ruoyao
2022-03-10  6:26     ` 程璐璐
2022-03-04  7:18 ` [PATCH v8 05/12] LoongArch Port: Machine description C files and .h files xuchenghua
2022-03-07 18:17   ` Richard Sandiford
2022-03-19  9:35     ` 程璐璐
2022-03-04  7:18 ` [PATCH v8 06/12] LoongArch Port: Builtin functions xuchenghua
2022-03-08 18:43   ` Richard Sandiford
2022-03-04  7:18 ` [PATCH v8 07/12] LoongArch Port: Builtin macros xuchenghua
2022-03-04  7:18 ` [PATCH v8 08/12] LoongArch Port: libgcc xuchenghua
2022-03-08 18:59   ` Richard Sandiford
2022-03-08 19:37     ` Andreas Schwab
2022-03-04  7:18 ` [PATCH v8 09/12] LoongArch Port: Regenerate libgcc/configure xuchenghua
2022-03-04  7:18 ` [PATCH v8 10/12] LoongArch Port: libgomp xuchenghua
2022-03-04  7:18 ` [PATCH v8 11/12] LoongArch Port: gcc/testsuite xuchenghua
2022-03-08 19:06   ` Richard Sandiford [this message]
2022-03-04  7:18 ` [PATCH v8 12/12] LoongArch Port: Add doc xuchenghua
2022-03-08 19:53   ` Richard Sandiford
2022-03-04 20:02 ` [PATCH v8 00/12] Add LoongArch support Xi Ruoyao
2022-03-05  1:36   ` Paul Hua
2022-03-05  1:39     ` Paul Hua
2022-03-05  9:21     ` Xi Ruoyao
2022-03-08 19:57   ` Richard Sandiford
2022-03-15 14:35 ` Xi Ruoyao
2022-03-16 12:31   ` 程璐璐

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mptsfrsgt7p.fsf@arm.com \
    --to=richard.sandiford@arm.com \
    --cc=chenglulu@loongson.cn \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    --cc=xuchenghua@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).