From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80088.outbound.protection.outlook.com [40.107.8.88]) by sourceware.org (Postfix) with ESMTPS id 63713396AC36 for ; Mon, 15 Feb 2021 15:53:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 63713396AC36 Received: from DB6PR0801CA0043.eurprd08.prod.outlook.com (2603:10a6:4:2b::11) by AM0PR08MB5428.eurprd08.prod.outlook.com (2603:10a6:208:182::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.25; Mon, 15 Feb 2021 15:53:47 +0000 Received: from DB5EUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:2b:cafe::93) by DB6PR0801CA0043.outlook.office365.com (2603:10a6:4:2b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.25 via Frontend Transport; Mon, 15 Feb 2021 15:53:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT025.mail.protection.outlook.com (10.152.20.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.25 via Frontend Transport; Mon, 15 Feb 2021 15:53:47 +0000 Received: ("Tessian outbound c07266d0ef38:v71"); Mon, 15 Feb 2021 15:53:47 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c04c3d8ca0a436d5 X-CR-MTA-TID: 64aa7808 Received: from 366037079485.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DE0CFD00-825B-4A5F-B3F7-194BDD793C73.1; Mon, 15 Feb 2021 15:53:34 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 366037079485.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 15 Feb 2021 15:53:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V+YR+5vi2TufvzQszpCPVfjZ6l7fr51sijAvHMOF7xRm9UTYypYZrhtKI/IFvi+HWi25x92bddXGeSyZBAMvcSmK4YJE/sy/+QS72OjkJzpinaeenP7XmjGJBRZ5OgRaIjs2mI31bSW9mPC5NUUMhhZyb+sHHAUH2Mwi2qiw1eugfK2+0W7Ls4QSq5bz45zAuraPXbfUMOqW1xnK4uxMTK2PjBWyHYTkWcsvMWAZnvwlSW3sjNFNrFBwa6uF+x6ArltGo6cBOFlUVbeuFo2nai30FAQ4JuIlYWPXpFoi2ThV+z0yqPa1uawJrBtR9w/cfVBOXqimiLn7Z+c7qIH1ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=83w4niOMwA0MCfzhO2ErSMG6HUvkAx4LLMfvdCEbrTQ=; b=KTGMQEedcJyQ0AzvQzSohjhs5FDqv95Ju5KpSy8F/m+wwH62oQFgoMQ4MVtFgwXg+sSyc3wFbYVIltb2BE2nDBN92rnuhxxokPxbp8dNh2xvnLZJ/n0aRhDRIXjk//IYm26tmUE8TMCuD+/SRJ/kEYG1AIHdqqWgAHTVIb9GzpJ0BLHEpRyLutIwvRtSBG4x3L9Sr60ANUY4IdLKyGqwF0mEEsVy5Hw90nDW+OpbdSE+yPchEVkQW6fHOcQ5iROyEbRi03Cpo4I0Qd9frcTAJolEtuQW1v1tlqcrwiYIpM27WfVmvybRb2/CQrDTfD/ii8G2rtJtMIXPtjo5p7oDxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from DBAPR08MB5589.eurprd08.prod.outlook.com (2603:10a6:10:1a2::23) by DBBPR08MB6314.eurprd08.prod.outlook.com (2603:10a6:10:20f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.39; Mon, 15 Feb 2021 15:53:32 +0000 Received: from DBAPR08MB5589.eurprd08.prod.outlook.com ([fe80::2dfb:2db4:7d15:9903]) by DBAPR08MB5589.eurprd08.prod.outlook.com ([fe80::2dfb:2db4:7d15:9903%6]) with mapi id 15.20.3846.042; Mon, 15 Feb 2021 15:53:32 +0000 From: Richard Sandiford To: Victor Do Nascimento via Gcc-patches Mail-Followup-To: Victor Do Nascimento via Gcc-patches , Victor Do Nascimento , nd , Richard Earnshaw , richard.sandiford@arm.com Cc: Victor Do Nascimento , nd , Richard Earnshaw Subject: Re: [PATCH][AArch64] Leveraging the use of STP instruction for vec_duplicate In-Reply-To: (Victor Do Nascimento via Gcc-patches's message of "Thu, 11 Feb 2021 17:46:47 +0000") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Date: Mon, 15 Feb 2021 15:53:30 +0000 Message-ID: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [217.140.106.32] X-ClientProxiedBy: LO2P265CA0381.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::33) To DBAPR08MB5589.eurprd08.prod.outlook.com (2603:10a6:10:1a2::23) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (217.140.106.32) by LO2P265CA0381.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.38 via Frontend Transport; Mon, 15 Feb 2021 15:53:31 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: dbc7a85e-8d65-46a8-622f-08d8d1c9e172 X-MS-TrafficTypeDiagnostic: DBBPR08MB6314:|AM0PR08MB5428: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: PXHm7dL3nY+GJE0lTje+9EwpC65Pk1HwSjqMNiWo0yG2ty0BwnwAdtWhb6ooEzrCoqG3AMpZAfTIwSslC3fMfqe3tlQ2Ei4caOYSToR8fB3Um8hbctl+nbWd2zei9vgJKqrybjJaaG5RoiUrwANq/U7l4fEjhNPF5uVRsaI9VtcdOYBeVWANUBhoyoZfWJ1rB4NBnUIDbrfYFKonLXmJYofaeNB9Vtu9N3e3sJGq778g1ipek3P3C7RuPsbWghdTwKM5eEXl4QNFIjze+2wG+ujKVINX+Fu3CZbg+2ouyfSCDxC4Oo4libDGPSyIY289wwoSxrEqXG5gNO34KJebUeP7PXC2ldWZ717LXEUY9JZYoR0hfUhijo815PS+0Ez96HSS1sZqa+XwDwd1RMgYtVhB1nAkD/B5Cpk629m26bMkictOnRW1xRHRXxbIG02TS+qMEpM0ANih1W90bgDNzSBL5Qz+RV+P+9GRuyjS1E9WKhjJ78ycKgUBMJOhUZlmUn6+Imf9XtqJqGRmZc5oUw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5589.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(376002)(346002)(39860400002)(396003)(366004)(8936002)(36756003)(66946007)(5660300002)(6916009)(478600001)(66556008)(186003)(8676002)(52116002)(44832011)(2906002)(956004)(2616005)(16526019)(26005)(6486002)(66476007)(4326008)(316002)(86362001)(6496006)(54906003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?cCtTQ3ljT2pLN1VMeTllSFFGYVlUUUNtT29YbjBWSEFQdXpLdGhRNUVZOC8v?= =?utf-8?B?UDNMNk9WT08rQlcrOXQrbVFTVnZyRXhBcWFHeHQ3YTByZHV3V2x2KzhaWjFO?= =?utf-8?B?YjRIOEd4dnV6TE12eDF6RlZQYlVuaDdKZTE1LzNTRXh2b3o4S3BSYkN5cm9t?= =?utf-8?B?NWlmckN2YjJOemJ5a3IyKy9EZnNMV0tJM3FWWXhzYmJtNDB4ZURyaTM0UVZ1?= =?utf-8?B?M003ZlkrMmd1TUo2YUFpUEVFVngwT1pITE4xaFl0MTdra3dpc1d1S2pjWVpN?= =?utf-8?B?THhyeGRWbC9SN3hnTUlpcW9manl4OFZ2OEI0cnRYaHh5S1JpQm83bm14OXpJ?= =?utf-8?B?YkltZWdJTWhySEgzdXpsVnAwWUZZSHFDd1crUndqUTNyUFpERHZndnVpK04z?= =?utf-8?B?OVp0VHh1eTBMYUFNNHBvRWZnalNuMnZqaFlXdVlrZmJLRVozMExnbVRJUjB4?= =?utf-8?B?eHUvaVdLbUUyMUJPRHJFTEMrSjhxK1dkMVNwbVNCTUErNjBrYW5oUmxUbVlz?= =?utf-8?B?a3kvYnVZbkNFVm5hak9jK2JRYk1seTYxOUUvT2k5MDNUVjBNKzd3M2ZwWThm?= =?utf-8?B?KzUxZjV6aG9GczhVUkM5bFVkcDZBbGNmOHVrMzR4Tmp6RG5tcEVTRXlFaVd5?= =?utf-8?B?c20wajdUWjYySnA0QXY4bG4xZGVqdHBHdGJRcHlGME9kTVFmRHcwRGtlVXpH?= =?utf-8?B?Tkg4WmllallDM0g2TGNkMGRmYlExTldTVzZsK2EvTWsza1c1Q2dOVWc3M2VP?= =?utf-8?B?dHJMQ2huVzJGV3I1UFJRdmhFaGZPdjl2RmUvQTVBMHdRRVNBOEg1T1kyVUdU?= =?utf-8?B?dXJVcmo4S0dpRkgrcStYNjhoN3YrbHlXb2FVTFNPOGFWamlUcC9uVGo2UzNR?= =?utf-8?B?cHg0OUJyV0toWTVScTQ5VkIyQ1doUUNMWTRsK3JrL3JWcFptNnpQYnNCek0y?= =?utf-8?B?QmRDWVF4cWVvWjZzVms2cFBic3JhbndVS2JvNFM3VHMycUxLeC91dkRFa0dv?= =?utf-8?B?TFVlOGtEY0dtd25rL2pnZnFVR1NnMGFuNXNiOUpiZm8wVmpCR09vaUN2UE5O?= =?utf-8?B?N0piOEJmU0FIVEt0NWVvZXFreGdxVE94cWZQQkpnejUwdjJIMENSNlZjNU1Z?= =?utf-8?B?aXRDZWxOdzJIL1hWemdIbnFPYlNvOCtCcnpMaGxIQkFkSGdFUXpmQy9FYUdN?= =?utf-8?B?dWxMODlzZVJQaDhWQ2VQZlpJRng3dHl3Q1FRZjd1Z0wwd0ttcVBTbVhZRVNt?= =?utf-8?B?NlBLTU4yWE9vcUxVcGVUZ0ZZZzZKUWJTK3U4b1hObFZBbXhMb2VBWmhVWHBl?= =?utf-8?B?RDZOdW0zTjBWdmV6TWJUZ2l4SjVpVkh4d3pDSm83YU5USm5qM0pYbzd5eVgv?= =?utf-8?B?L2FUeGJmanVxR0ErYzZWb0ZseHViOE01TitqQUJzVVBKQjF1M3FsYURrSVpx?= =?utf-8?B?US9ORHN1eHdnekxFSXlTTmJQUDNjY1dRY0pwMWxJbFlsMk1ING9pYStkR0lW?= =?utf-8?B?cWdrWTNnejlQSnNEZ2haQUZJbUxXcVByNGlweGw2QkhzMGFKWS9DaDlFT2ZI?= =?utf-8?B?QlFmT3NXSm9qNTBPaXQxM0NnOEdvaXlBL3JkTi8zRHpMVDFJN2EyWDc3d3VO?= =?utf-8?B?V0lpZ3dEMU9GRlBvZ0FtcHBtZkhHY3lGaDVLY2VpdUZpSW5PSFM5MzFFNXJH?= =?utf-8?B?OWxmTXRTZnEwRlYxbXFPNVQ5NWtwdlM4NnV1ZTRlY0w1ZjdGWXBCdkxxRGhU?= =?utf-8?Q?VXlvtRFmz0nwlUuIq8nZ0o/ccBDCIiw390KFA6c?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6314 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: fd7b0dd5-2731-4deb-ab0d-08d8d1c9d850 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /2FWkBaBrRFOkCY6oj3BFHK/hUFgw/4SCrN/GcUsDi2dt6vfqZdcYKH5DmULei/z5NpQCGjzSoLY0YOprZjrfmJPvGHpv8yIrryR45iR5My6OEs8TmC/Z5PmHpwxZowpGwzzno3gzNSW0LQBN9oARIm2riFEXE/xXVBXCbnYxvo+TD8h7fPThOFdiqEslZ4u0D81uuErNNbmTxwdH1o0KEUbFQ1C88tuR5/d/9aZVf2vhrJU+NjtobVaTvf8DynH8Ne8Lwu51rrWNVCZCxlzMtieticF262fEXdNBFi9gvKUxQtiz8SSV97sQ9j/7p3QdR20shAab2h91VpBLIGECFAtYtwgYW+Qf2C4c4KPEtR9x13HwoooIqVSLB97xs6M0liRgXz2O2U6pzlc8Uu7aiBkhbTk9Tb+vd4aupSD+JNkRQhQqRdQGOvru28lkpnbvNHbQmUgZ14tSckrRDXzQEg1HWkcAN5csj8RhsaBkeomD8V3OkiVngDu4hocDDfXdfM0kTy+x/0nJyMVP48mNvckqT5C9BzNqlXFIBWcq2xytlrT2p9Siv7rKNvdQLXLAlJRBZ6zITrybze1yxUYb5loSA8QA+d4qJkzpnhWD/NSVRDYZhTf72kfojzAThQsJqJirGKHRCaQmPBfKBAKg5kG2ZOupDBAuYjxwe3Laf0= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(376002)(39860400002)(346002)(136003)(396003)(36840700001)(46966006)(16526019)(478600001)(8676002)(47076005)(54906003)(4326008)(316002)(36860700001)(186003)(44832011)(36756003)(336012)(2616005)(956004)(356005)(5660300002)(81166007)(6486002)(82740400003)(86362001)(6496006)(8936002)(26005)(70586007)(70206006)(6916009)(82310400003)(2906002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2021 15:53:47.3856 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dbc7a85e-8d65-46a8-622f-08d8d1c9e172 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5428 X-Spam-Status: No, score=-14.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 15:53:51 -0000 Hi Victor, Thanks for the patch. I have a couple of very minor comments below, but otherwise it looks good to go. However, it will need to wait for stage 1 to open, unless it fixes a regression. Victor Do Nascimento via Gcc-patches writes: > diff --git a/gcc/config/aarch64/aarch64-simd.md b/gcc/config/aarch64/aarc= h64-simd.md > index 68baf416045..4623cbb95f4 100644 > --- a/gcc/config/aarch64/aarch64-simd.md > +++ b/gcc/config/aarch64/aarch64-simd.md > @@ -205,6 +205,16 @@ > [(set_attr "type" "neon_stp")] > ) > =20 > +(define_insn "aarch64_simd_stp" > + [(set (match_operand:VP_2E 0 "aarch64_mem_pair_operand" "=3DUmp,Ump"= ) > + (vec_duplicate:VP_2E (match_operand: 1 "register_operand" "w,= r")))] > + "TARGET_SIMD" > + "@ > + stp\\t%1, %1, %z0 > + stp\\t%1, %1, %z0" > + [(set_attr "type" "neon_stp, store_")] Minor formatting nit, but: these patterns are generally indented by 2 spaces rather than 4 (at least in config/aarch64). Also, it would be good if the (vec_duplicate:=E2=80=A6) lined up with the (match_operand:=E2=80=A6) I think the type for the first alternative should be neon_stp rather than neon_stp. The instruction only ever stores S or D registers, whereas neon_stp_q is for storing Q registers. Thanks, Richard