From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 2A04F38618B8 for ; Mon, 11 Jan 2021 12:17:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2A04F38618B8 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B457831B; Mon, 11 Jan 2021 04:17:56 -0800 (PST) Received: from localhost (e121540-lin.manchester.arm.com [10.32.98.126]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4064E3F719; Mon, 11 Jan 2021 04:17:56 -0800 (PST) From: Richard Sandiford To: "Qian\, Jianhua" Mail-Followup-To: "Qian\, Jianhua" , "gcc-patches\@gcc.gnu.org" , richard.sandiford@arm.com Cc: "gcc-patches\@gcc.gnu.org" Subject: Re: [PATCH v2] aarch64: Add cpu cost tables for A64FX References: <20210104055306.9568-1-qianjh@cn.fujitsu.com> Date: Mon, 11 Jan 2021 12:17:54 +0000 In-Reply-To: (Jianhua Qian's message of "Mon, 11 Jan 2021 04:36:17 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2021 12:17:59 -0000 "Qian, Jianhua" writes: > Hi Richard > >> -----Original Message----- >> From: Richard Sandiford >> Sent: Friday, January 8, 2021 7:04 PM >> To: Qian, Jianhua/=E9=92=B1 =E5=BB=BA=E5=8D=8E >> Cc: gcc-patches@gcc.gnu.org >> Subject: Re: [PATCH v2] aarch64: Add cpu cost tables for A64FX >>=20 >> Qian Jianhua writes: >> > This patch add cost tables for A64FX. >> > >> > ChangeLog: >> > 2021-01-08 Qian jianhua >> > >> > gcc/ >> > * config/aarch64/aarch64-cost-tables.h (a64fx_extra_costs): New. >> > * config/aarch64/aarch64.c (a64fx_addrcost_table): New. >> > (a64fx_regmove_cost, a64fx_vector_cost): New. >> > (a64fx_tunings): Use the new added cost tables. >>=20 >> OK for trunk, thanks. The v1 patch is OK for branches that support >> -mcpu=3Da64fx. >>=20 >> Would you like commit access, so that you can commit it yourself? >> If so, please fill out the form mentioned at the beginning of >> https://gcc.gnu.org/gitwrite.html listing me as sponsor. >>=20 > It=E2=80=98s my pleasure. I've applied it. Great! > Thank you so much. > > I don't quite know the process of gcc source committing. > If I have the commit access, how will process be different? The patch submission process is pretty much the same: patches need to be sent to the list and most patches need to be approved by a reviewer or maintainer. The main differences are: - If a patch is =E2=80=9Cobviously correct=E2=80=9D, you can apply it witho= ut going through the approval process. (Please still send the patch to the list though.) - Once a patch has been approved, you can commit the patch yourself, rather than rely on someone else to do it for you. The main benefits of this are: - You can commit from the tree that you actually tested. - You can deal with any merge conflicts caused by other people's patches without having to go through another review cycle. (Most merge conflict resolutions are =E2=80=9Cobvious=E2=80=9D and so don't n= eed approval.) - A typical workflow is to test a patch on trunk, post it for review, and ask for approval to apply the patch to both trunk and whichever branches are appropriate. If the patch is approved, you can later test the patch on the approved branches (at your own pace) and apply it if the tests pass. In terms of the mechanics of committing, just =E2=80=9Cgit push=E2=80=9D sh= ould work. The server hooks will check for things like a well-formed changelog. https://gcc.gnu.org/gitwrite.html has more info about the process in general. Quoting from that page, the next step is: Check out a tree using the instructions below and add yourself to the MAINTAINERS file. Note: Your first and last names must be exactly the same between your account on gcc.gnu.org and the MAINTAINERS file. Place your name in the correct section following the conventions specified in the file (e.g. "Write After Approval" is "last name alphabetical order"). Then produce a diff to that file and circulate it to the gcc-patches list, whilst also checking in your change to test write access (approval from the mailing list is not needed in this one case). For all other changes, please be sure to follow the write access policies below. > And which branch, which range(aarch64?) could I commit patches to? This patch should go to master. The v1 patch should go to releases/gcc-10 and releases/gcc-9. You might need to remove some lines from the cost tables when backporting to gcc-10 and gcc-9 (I haven't checked). If so, that kind of change counts as =E2=80=9Cobviously correct=E2=80=9D and so doesn't need= approval. Hope this helps. Please let me know if you have any questions. Thanks, Richard