From: Richard Sandiford <richard.sandiford@arm.com>
To: Alexandre Oliva via Gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Alexandre Oliva <oliva@adacore.com>,
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
Mike Stump <mikestump@comcast.net>
Subject: Re: [PATCH] [testsuite] [arm/aarch64] -fno-short-enums for auto-init-[12].c
Date: Mon, 05 Dec 2022 07:33:34 +0000 [thread overview]
Message-ID: <mpttu2a1f01.fsf@arm.com> (raw)
In-Reply-To: <orwn7axilx.fsf@lxoliva.fsfla.org> (Alexandre Oliva via Gcc-patches's message of "Fri, 02 Dec 2022 06:25:30 -0300")
Alexandre Oliva via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
> On arm-eabi, and possibly on other platforms, -fshort-enums is enabled
> by default, which breaks some tests' expectations as to enum sizes
> with DEFERRED_INIT. Disable short enums so that the expectations are
> met.
>
> Regstraped on x86_64-linux-gnu, also tested with crosses to riscv64-elf
> and arm-eabi. Ok to install?
OK, thanks.
Richard
> for gcc/testsuite/ChangeLog
>
> * c-c++-common/auto-init-1.c: Add -fno-short-enums.
> * c-c++-common/auto-init-2.c: Likewise.
> * gcc.dg/debug/btf/btf-enum-1.c: Likewise.
> ---
> gcc/testsuite/c-c++-common/auto-init-1.c | 2 +-
> gcc/testsuite/c-c++-common/auto-init-2.c | 2 +-
> gcc/testsuite/gcc.dg/debug/btf/btf-enum-1.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/testsuite/c-c++-common/auto-init-1.c b/gcc/testsuite/c-c++-common/auto-init-1.c
> index df04358728bab..3e6a4984eea22 100644
> --- a/gcc/testsuite/c-c++-common/auto-init-1.c
> +++ b/gcc/testsuite/c-c++-common/auto-init-1.c
> @@ -1,6 +1,6 @@
> /* Verify zero initialization for integer and pointer type automatic variables. */
> /* { dg-do compile { target { ilp32 || lp64 } } } */
> -/* { dg-options "-ftrivial-auto-var-init=zero -fdump-tree-gimple" } */
> +/* { dg-options "-ftrivial-auto-var-init=zero -fno-short-enums -fdump-tree-gimple" } */
>
> #ifndef __cplusplus
> # define bool _Bool
> diff --git a/gcc/testsuite/c-c++-common/auto-init-2.c b/gcc/testsuite/c-c++-common/auto-init-2.c
> index 6ac63bb1ddac1..d356e508b836f 100644
> --- a/gcc/testsuite/c-c++-common/auto-init-2.c
> +++ b/gcc/testsuite/c-c++-common/auto-init-2.c
> @@ -1,6 +1,6 @@
> /* Verify pattern initialization for integer and pointer type automatic variables. */
> /* { dg-do compile { target { ilp32 || lp64 } } } */
> -/* { dg-options "-ftrivial-auto-var-init=pattern -fdump-tree-gimple" } */
> +/* { dg-options "-ftrivial-auto-var-init=pattern -fno-short-enums -fdump-tree-gimple" } */
>
> #ifndef __cplusplus
> # define bool _Bool
> diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-enum-1.c b/gcc/testsuite/gcc.dg/debug/btf/btf-enum-1.c
> index 7e940529f1b6d..2887cb1c5f244 100644
> --- a/gcc/testsuite/gcc.dg/debug/btf/btf-enum-1.c
> +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-enum-1.c
> @@ -1,7 +1,7 @@
> /* Test BTF generation for enums. */
>
> /* { dg-do compile } */
> -/* { dg-options "-O0 -gbtf -dA" } */
> +/* { dg-options "-O0 -gbtf -fno-short-enums -dA" } */
>
> /* { dg-final { scan-assembler-times "\[\t \]0x6000004\[\t \]+\[^\n\]*btt_info" 1 } } */
> /* { dg-final { scan-assembler-times "\[\t \]0x86000003\[\t \]+\[^\n\]*btt_info" 1 } } */
prev parent reply other threads:[~2022-12-05 7:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 9:25 Alexandre Oliva
2022-12-05 7:33 ` Richard Sandiford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mpttu2a1f01.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikestump@comcast.net \
--cc=oliva@adacore.com \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).