From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id EE0803858CDB for ; Thu, 18 May 2023 08:57:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EE0803858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 580471FB; Thu, 18 May 2023 01:57:54 -0700 (PDT) Received: from localhost (e121540-lin.manchester.arm.com [10.32.110.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 78D3E3F73F; Thu, 18 May 2023 01:57:08 -0700 (PDT) From: Richard Sandiford To: pan2.li@intel.com Mail-Followup-To: pan2.li@intel.com,gcc-patches@gcc.gnu.org, juzhe.zhong@rivai.ai, kito.cheng@sifive.com, yanzhang.wang@intel.com, jeffreyalaw@gmail.com, rguenther@suse.de, richard.sandiford@arm.com Cc: gcc-patches@gcc.gnu.org, juzhe.zhong@rivai.ai, kito.cheng@sifive.com, yanzhang.wang@intel.com, jeffreyalaw@gmail.com, rguenther@suse.de Subject: Re: [PATCH] Machine_Mode: Extend machine_mode from 8 to 16 bits References: <20230512050016.476110-1-pan2.li@intel.com> <20230516153524.3302940-1-pan2.li@intel.com> Date: Thu, 18 May 2023 09:57:07 +0100 In-Reply-To: <20230516153524.3302940-1-pan2.li@intel.com> (pan2's message of "Tue, 16 May 2023 23:35:24 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-29.0 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: pan2.li@intel.com writes: > diff --git a/gcc/rtl-ssa/accesses.h b/gcc/rtl-ssa/accesses.h > index c5180b9308a..c2103a5cb5c 100644 > --- a/gcc/rtl-ssa/accesses.h > +++ b/gcc/rtl-ssa/accesses.h > @@ -215,7 +215,11 @@ private: > > // The values returned by the accessors above. > unsigned int m_regno; > - access_kind m_kind : 8; > + > + // The value returned by the accessor above. > + machine_mode m_mode : MACHINE_MODE_BITSIZE; > + > + access_kind m_kind : 2; There's no need to repeat the comment. Just: // The values returned by the accessors above. unsigned int m_regno; machine_mode m_mode : MACHINE_MODE_BITSIZE; access_kind m_kind : 2; would be enough. OK with that change, thanks. (There's no need to post the updated patch.) Richard