From: Richard Sandiford <richard.sandiford@arm.com>
To: Richard Biener via Gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Richard Biener <rguenther@suse.de>
Subject: Re: [PATCH 2/2] Revert maybe_ne -> known_ne change in vn_reference_lookup_3
Date: Fri, 01 Jul 2022 13:34:02 +0100 [thread overview]
Message-ID: <mptv8sh6mh1.fsf@arm.com> (raw)
In-Reply-To: <20220701121951.C85F413A20@imap2.suse-dmz.suse.de> (Richard Biener via Gcc-patches's message of "Fri, 1 Jul 2022 14:19:51 +0200 (CEST)")
Richard Biener via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
> This reverts the change as discussed.
Thanks!
> Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed.
>
> 2022-07-01 Richard Biener <rguenther@suse.de>
>
> * tree-ssa-sccvn.cc (vn_reference_lookup_3): Revert
> back to using maybe_ne (off, -1).
> ---
> gcc/tree-ssa-sccvn.cc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/tree-ssa-sccvn.cc b/gcc/tree-ssa-sccvn.cc
> index c40c45ed840..f41d5031365 100644
> --- a/gcc/tree-ssa-sccvn.cc
> +++ b/gcc/tree-ssa-sccvn.cc
> @@ -3243,12 +3243,12 @@ vn_reference_lookup_3 (ao_ref *ref, tree vuse, void *data_,
> poly_int64 extra_off = 0;
> if (j == 0 && i >= 0
> && lhs_ops[0].opcode == MEM_REF
> - && known_ne (lhs_ops[0].off, -1))
> + && maybe_ne (lhs_ops[0].off, -1))
> {
> if (known_eq (lhs_ops[0].off, vr->operands[i].off))
> i--, j--;
> else if (vr->operands[i].opcode == MEM_REF
> - && known_ne (vr->operands[i].off, -1))
> + && maybe_ne (vr->operands[i].off, -1))
> {
> extra_off = vr->operands[i].off - lhs_ops[0].off;
> i--, j--;
prev parent reply other threads:[~2022-07-01 12:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 12:19 Richard Biener
2022-07-01 12:34 ` Richard Sandiford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mptv8sh6mh1.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).