public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Sandiford <richard.sandiford@arm.com>
To: Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
Cc: gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [SVE] [fwprop] PR88833 - Redundant moves for WHILELO-based loops
Date: Mon, 24 Jun 2019 14:21:00 -0000	[thread overview]
Message-ID: <mptv9wvgj37.fsf@arm.com> (raw)
In-Reply-To: <CAAgBjM=z6g3R6Ai7nRcOShAXEp2dd44kFkmZUUf-=T+jfUFboQ@mail.gmail.com>	(Prathamesh Kulkarni's message of "Mon, 24 Jun 2019 17:06:37 +0530")

Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org> writes:
> @@ -1415,6 +1460,19 @@ forward_propagate_into (df_ref use)
>    if (!def_set)
>      return false;
>  
> +  if (reg_prop_only
> +      && !REG_P (SET_SRC (def_set))
> +      && !REG_P (SET_DEST (def_set)))
> +    return false;

This should be:

  if (reg_prop_only
      && (!REG_P (SET_SRC (def_set)) || !REG_P (SET_DEST (def_set))))
    return false;

so that we return false if either operand isn't a register.

> +
> +  /* Allow propagations into a loop only for reg-to-reg copies, since
> +     replacing one register by another shouldn't increase the cost.  */
> +
> +  if (DF_REF_BB (def)->loop_father != DF_REF_BB (use)->loop_father
> +      && !REG_P (SET_SRC (def_set))
> +      && !REG_P (SET_DEST (def_set)))
> +    return false;

Same here.

OK with that change, thanks.

Richard

  reply	other threads:[~2019-06-24 14:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-21  9:52 Prathamesh Kulkarni
2019-06-24  9:29 ` Richard Sandiford
2019-06-24 11:37   ` Prathamesh Kulkarni
2019-06-24 14:21     ` Richard Sandiford [this message]
2019-06-24 16:12       ` Prathamesh Kulkarni
2019-06-25 12:06         ` Prathamesh Kulkarni
2019-06-25 14:35           ` Richard Sandiford
2019-06-26 10:10             ` Prathamesh Kulkarni
2019-06-26 10:35               ` Richard Sandiford
2019-06-26 13:55                 ` Prathamesh Kulkarni
2019-06-26 18:15                   ` Richard Sandiford
2019-07-02 11:20                     ` Prathamesh Kulkarni
2019-07-02 11:29                       ` Richard Sandiford
2019-07-02 12:10                         ` Prathamesh Kulkarni
2019-07-02 12:52                           ` Richard Sandiford
2019-07-03 10:46                             ` Prathamesh Kulkarni
2019-07-03 11:36                               ` Richard Sandiford
2019-07-04  6:50                                 ` Prathamesh Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mptv9wvgj37.fsf@arm.com \
    --to=richard.sandiford@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=prathamesh.kulkarni@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).