From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id A6C973858D28 for ; Thu, 2 Nov 2023 23:49:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A6C973858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A6C973858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698968943; cv=none; b=durksuVcE5BP2rIJiNUzrnPDzyYfsm5bRneRp2GBaooqIcJdOITMXivW/26WgFS8tMb+KKf2VqGMuM6ertX23PXTYiCil6kOHD1OaYzfpBO1Rp/H2FDJ92APqEkrGo4YYAWZy2sz6BShYFyKHhni2aqLrW00WJT9EgXLYwNmoow= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698968943; c=relaxed/simple; bh=gD0ZnqnEdyUF4f//xdbjYGZ01BE73nH66bP10HRKv2M=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=Ikzry9pAB9YpDzyCIZ/zsNKCa74NF4xqhkHmlOq/e8oUQSm7AGK9Ro/MznQ2Yfq/6TRWO9+jCNN1x8FKwVTJFlmefuanIiUvICTgOZhfw9N/5CRSnXXWR4mUS76dTCyv9ABm9aKcPWHSSMYmeXVP4irR0g3QiNHqZMw7Q7v13Ng= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A0CE22F4; Thu, 2 Nov 2023 16:49:44 -0700 (PDT) Received: from localhost (e121540-lin.manchester.arm.com [10.32.110.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7B3BB3F738; Thu, 2 Nov 2023 16:49:01 -0700 (PDT) From: Richard Sandiford To: Robin Dapp Mail-Followup-To: Robin Dapp ,Richard Biener , gcc-patches , "juzhe.zhong\@rivai.ai" , richard.sandiford@arm.com Cc: Richard Biener , gcc-patches , "juzhe.zhong\@rivai.ai" Subject: Re: [PATCH] internal-fn: Add VCOND_MASK_LEN. References: <818fe7b8-cb55-49d1-94fa-f929b8cbc5d8@gmail.com> <430d3b7e-acc3-43bb-9d3e-7897aa7d2e83@gmail.com> Date: Thu, 02 Nov 2023 23:49:00 +0000 In-Reply-To: <430d3b7e-acc3-43bb-9d3e-7897aa7d2e83@gmail.com> (Robin Dapp's message of "Thu, 2 Nov 2023 14:48:20 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-17.5 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Robin Dapp writes: >> Looks reasonable overall. The new match patterns are 1:1 the >> same as the COND_ ones. That's a bit awkward, but I don't see >> a good way to "macroize" stuff further there. Can you at least >> interleave the COND_LEN_* ones with the other ones instead of >> putting them all at the end? > > Yes, no problem. It's supposed to be only temporary anyway (FWIW) > as I didn't manage with the "stripping _LEN" way on the first few tries. > Still on the todo list but unlikely to be done before stage 1 closes. > > I believe Richard "kind of" LGTM'ed the rest minus the spurious > pattern (which is gone now) but there is still the direct optab change > that he didn't comment on so I think we should wait for his remarks > still. Could you explain why a special expansion is needed? (Sorry if you already have and I missed it, bit overloaded ATM.) What does it do that is different from what expand_fn_using_insn would do? Thanks, Richard