From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 57690384AB45; Wed, 15 May 2024 11:07:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 57690384AB45 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 57690384AB45 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715771222; cv=none; b=PT+1BXUasJJwKcKG3kQZpXKVeGKkah7CYG/IdRXcBVpphwWBI7eAUyxSsqHDVpQpWgaSqR2w+g7DNtY+GdSOkASZrlUDWKYJQ8ttgGG4+yyFWS/msCNOHocLgZAct5CNKN/y7e8pSv/CFFihtfjdPQh9glV0xPz7kChCx5Ag3ug= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715771222; c=relaxed/simple; bh=y+qoahoqkj0pUJxqnsahzl6CID0wD2Mt1VxuYVyb/Oc=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=CiNSG+khsevKY5278rdMOa0l3oVav6tAXWZLq27ntwytKz6Du2CiiDVgmZSNz177UsmEDpIS5oP1Po6PBFC0I79cyKfJhhwnDMNkj1MGHZEPBzyp/L+qWGbxbD41larHSSWzbEqJQeDzim986dN4nGVJvwJkPvyk5fI4dtVWWds= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9FC421042; Wed, 15 May 2024 04:07:25 -0700 (PDT) Received: from localhost (e121540-lin.manchester.arm.com [10.32.110.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 199D93F762; Wed, 15 May 2024 04:06:59 -0700 (PDT) From: Richard Sandiford To: Tamar Christina Mail-Followup-To: Tamar Christina ,gcc-patches@gcc.gnu.org, nd@arm.com, Richard.Earnshaw@arm.com, Marcus.Shawcroft@arm.com, ktkachov@gcc.gnu.org, richard.sandiford@arm.com Cc: gcc-patches@gcc.gnu.org, nd@arm.com, Richard.Earnshaw@arm.com, Marcus.Shawcroft@arm.com, ktkachov@gcc.gnu.org Subject: Re: [PATCH 1/4]AArch64: convert several predicate patterns to new compact syntax References: Date: Wed, 15 May 2024 12:06:58 +0100 In-Reply-To: (Tamar Christina's message of "Wed, 15 May 2024 11:28:32 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-14.5 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks for doing this a pre-patch. Minor request below: Tamar Christina writes: > ;; Perform a logical operation on operands 2 and 3, using operand 1 as > @@ -6676,38 +6690,42 @@ (define_insn "@aarch64_pred__z" > (define_insn "*3_cc" > [(set (reg:CC_NZC CC_REGNUM) > (unspec:CC_NZC > - [(match_operand:VNx16BI 1 "register_operand" "Upa") > + [(match_operand:VNx16BI 1 "register_operand") > (match_operand 4) > (match_operand:SI 5 "aarch64_sve_ptrue_flag") > (and:PRED_ALL > (LOGICAL:PRED_ALL > - (match_operand:PRED_ALL 2 "register_operand" "Upa") > - (match_operand:PRED_ALL 3 "register_operand" "Upa")) > + (match_operand:PRED_ALL 2 "register_operand") > + (match_operand:PRED_ALL 3 "register_operand")) > (match_dup 4))] > UNSPEC_PTEST)) > - (set (match_operand:PRED_ALL 0 "register_operand" "=Upa") > + (set (match_operand:PRED_ALL 0 "register_operand") > (and:PRED_ALL (LOGICAL:PRED_ALL (match_dup 2) (match_dup 3)) > (match_dup 4)))] > "TARGET_SVE" > - "s\t%0.b, %1/z, %2.b, %3.b" > + {@ [ cons: =0, 1 , 2 , 3 , 4, 5 ] > + [ Upa , Upa, Upa, Upa, , ] s\t%0.b, %1/z, %2.b, %3.b > + } > ) Could we leave out these empty trailing constraints? They're quite common in SVE & SME patterns and are specifically not meant to influence instruction selection. E.g. we've done the same thing for *cnot (to pick a random example). Agree with Kyrill's ok otherwise. Richard