From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 6886E3846420 for ; Tue, 9 Apr 2024 15:48:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6886E3846420 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6886E3846420 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712677691; cv=none; b=xi7hgkOBoE0BEQIQu+Xeg3n7Pj+H2fWf4KMTluVV7u9BqnTBweWt6X7RKmfuSPdI7mUQjY2wdQQ9ZNeYiLoSe9MkmcJcw+69yySPsX7+smiMeXFjeB7HABO5upswGg4ZzpVylZFUE5rwLoXNCN897dR8KIhlukT+ivXBNpbL7T4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712677691; c=relaxed/simple; bh=BYsRj7ZrVcJmuztvaXXOgwpBO9fe+sh8X1DNtZR8WXc=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=ReX9KG7C4cL82FaA9qna6hEbv3waqg06Tx1BWL33uZ/ZDe8k/jvA0kPG4UDSYNtcCDzZEYp6znT/poTdxqk6iVIdXjB+SWxhzojv+WkQaVU05fEY/ErsHXUEc+OdZ0mDPQPShg9dzCYcZfmT+cDTFb5TCxXeVHO/s7x+mWeTH38= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4A964139F; Tue, 9 Apr 2024 08:48:38 -0700 (PDT) Received: from localhost (e121540-lin.manchester.arm.com [10.32.110.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3D5B13F6C4; Tue, 9 Apr 2024 08:48:07 -0700 (PDT) From: Richard Sandiford To: Tamar Christina Mail-Followup-To: Tamar Christina ,gcc-patches@gcc.gnu.org, nd@arm.com, Richard.Earnshaw@arm.com, Marcus.Shawcroft@arm.com, Kyrylo.Tkachov@arm.com, richard.sandiford@arm.com Cc: gcc-patches@gcc.gnu.org, nd@arm.com, Richard.Earnshaw@arm.com, Marcus.Shawcroft@arm.com, Kyrylo.Tkachov@arm.com Subject: Re: [PATCH]AArch64: Do not allow SIMD clones with simdlen 1 [PR113552][GCC 13/12/11 backport] References: Date: Tue, 09 Apr 2024 16:48:06 +0100 In-Reply-To: (Tamar Christina's message of "Tue, 9 Apr 2024 13:32:25 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-20.5 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_LOTSOFHASH,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tamar Christina writes: > Hi All, > > This is a backport of g:306713c953d509720dc394c43c0890548bb0ae07. > > The AArch64 vector PCS does not allow simd calls with simdlen 1, > however due to a bug we currently do allow it for num == 0. > > This causes us to emit a symbol that doesn't exist and we fail to link. > > Bootstrapped Regtested on aarch64-none-linux-gnu and no issues. > > OK for GCC 13,12,11 branches?. > > Thanks, > Tamar > > gcc/ChangeLog: > > PR tree-optimization/113552 > * config/aarch64/aarch64.cc > (aarch64_simd_clone_compute_vecsize_and_simdlen): Block simdlen 1. > > gcc/testsuite/ChangeLog: > > PR tree-optimization/113552 > * gcc.target/aarch64/pr113552.c: New test. > * gcc.target/aarch64/simd_pcs_attribute-3.c: Remove bogus check. OK, thanks. Richard > --- > diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc > index f546c48ae2d2bad2e34c6b72e5e3e30aba3c3bd6..cec614596c5532b6341ab814f700c4ffc737340f 100644 > --- a/gcc/config/aarch64/aarch64.cc > +++ b/gcc/config/aarch64/aarch64.cc > @@ -27027,7 +27027,7 @@ aarch64_simd_clone_compute_vecsize_and_simdlen (struct cgraph_node *node, > bool explicit_p) > { > tree t, ret_type; > - unsigned int elt_bits, count; > + unsigned int elt_bits, count = 0; > unsigned HOST_WIDE_INT const_simdlen; > poly_uint64 vec_bits; > > @@ -27100,8 +27100,17 @@ aarch64_simd_clone_compute_vecsize_and_simdlen (struct cgraph_node *node, > elt_bits = GET_MODE_BITSIZE (SCALAR_TYPE_MODE (base_type)); > if (known_eq (clonei->simdlen, 0U)) > { > - count = 2; > - vec_bits = (num == 0 ? 64 : 128); > + /* We don't support simdlen == 1. */ > + if (known_eq (elt_bits, 64)) > + { > + count = 1; > + vec_bits = 128; > + } > + else > + { > + count = 2; > + vec_bits = (num == 0 ? 64 : 128); > + } > clonei->simdlen = exact_div (vec_bits, elt_bits); > } > else > @@ -27121,6 +27130,7 @@ aarch64_simd_clone_compute_vecsize_and_simdlen (struct cgraph_node *node, > return 0; > } > } > + > clonei->vecsize_int = vec_bits; > clonei->vecsize_float = vec_bits; > return count; > diff --git a/gcc/testsuite/gcc.target/aarch64/pr113552.c b/gcc/testsuite/gcc.target/aarch64/pr113552.c > new file mode 100644 > index 0000000000000000000000000000000000000000..9c96b061ed2b4fcc57e58925277f74d14f79c51f > --- /dev/null > +++ b/gcc/testsuite/gcc.target/aarch64/pr113552.c > @@ -0,0 +1,17 @@ > +/* { dg-do compile } */ > +/* { dg-options "-Ofast -march=armv8-a" } */ > + > +__attribute__ ((__simd__ ("notinbranch"), const)) > +double cos (double); > + > +void foo (float *a, double *b) > +{ > + for (int i = 0; i < 12; i+=3) > + { > + b[i] = cos (5.0 * a[i]); > + b[i+1] = cos (5.0 * a[i+1]); > + b[i+2] = cos (5.0 * a[i+2]); > + } > +} > + > +/* { dg-final { scan-assembler-times {bl\t_ZGVnN2v_cos} 6 } } */ > diff --git a/gcc/testsuite/gcc.target/aarch64/simd_pcs_attribute-3.c b/gcc/testsuite/gcc.target/aarch64/simd_pcs_attribute-3.c > index 95f6a6803e889c02177ef10972962ed62d2095eb..c6dac6b104c94c9de89ed88dc5a73e185d2be125 100644 > --- a/gcc/testsuite/gcc.target/aarch64/simd_pcs_attribute-3.c > +++ b/gcc/testsuite/gcc.target/aarch64/simd_pcs_attribute-3.c > @@ -18,7 +18,7 @@ double foo(double x) > } > > /* { dg-final { scan-assembler-not {\.variant_pcs\tfoo} } } */ > -/* { dg-final { scan-assembler-times {\.variant_pcs\t_ZGVnM1v_foo} 1 } } */ > +/* { dg-final { scan-assembler-not {\.variant_pcs\t_ZGVnM1v_foo} } } */ > /* { dg-final { scan-assembler-times {\.variant_pcs\t_ZGVnM2v_foo} 1 } } */ > -/* { dg-final { scan-assembler-times {\.variant_pcs\t_ZGVnN1v_foo} 1 } } */ > +/* { dg-final { scan-assembler-not {\.variant_pcs\t_ZGVnN1v_foo} } } */ > /* { dg-final { scan-assembler-times {\.variant_pcs\t_ZGVnN2v_foo} 1 } } */