From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 579783858C50 for ; Thu, 31 Mar 2022 11:03:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 579783858C50 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B13E323A; Thu, 31 Mar 2022 04:03:58 -0700 (PDT) Received: from localhost (e121540-lin.manchester.arm.com [10.32.98.88]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3EB743F718; Thu, 31 Mar 2022 04:03:58 -0700 (PDT) From: Richard Sandiford To: Alexandre Oliva via Gcc-patches Mail-Followup-To: Alexandre Oliva via Gcc-patches , Alexandre Oliva , richard.sandiford@arm.com Cc: Alexandre Oliva Subject: Re: Test for linking for arm/size-optimization-ieee-[123].c References: Date: Thu, 31 Mar 2022 12:03:56 +0100 In-Reply-To: (Alexandre Oliva via Gcc-patches's message of "Wed, 30 Mar 2022 22:24:46 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2022 11:04:01 -0000 Alexandre Oliva via Gcc-patches writes: > These tests require a target that supports arm soft-float. The > problem is that the test checks for compile-time soft-float support, > but they may hit a problem when the linker complains that it can't > combine the testcase's object file with hard-float init files and > target system libraries. > > I don't see that the tests actually require linking, and they could be > simplified to dg-do assemble, but I figured a link test for soft-float > support could be useful, so I added that, and adjusted the tests to > require it instead. > > Tested on an affected platform. Ok to install? > > > for gcc/testsuite/ChangeLog > > * lib/target-supports.exp > (check_effective_target_arm_soft_ok_link): New. > * gcc.target/arm/size-optimization-ieee-1.c: Use it. > * gcc.target/arm/size-optimization-ieee-2.c: Likewise. > * gcc.target/arm/size-optimization-ieee-3.c: Likewise. OK, thanks. Richard > --- > .../gcc.target/arm/size-optimization-ieee-1.c | 2 +- > .../gcc.target/arm/size-optimization-ieee-2.c | 2 +- > .../gcc.target/arm/size-optimization-ieee-3.c | 2 +- > gcc/testsuite/lib/target-supports.exp | 12 ++++++++++++ > 4 files changed, 15 insertions(+), 3 deletions(-) > > diff --git a/gcc/testsuite/gcc.target/arm/size-optimization-ieee-1.c b/gcc/testsuite/gcc.target/arm/size-optimization-ieee-1.c > index 61475eb4c679f..9af2c6e102071 100644 > --- a/gcc/testsuite/gcc.target/arm/size-optimization-ieee-1.c > +++ b/gcc/testsuite/gcc.target/arm/size-optimization-ieee-1.c > @@ -1,4 +1,4 @@ > -/* { dg-do link { target arm_soft_ok } } */ > +/* { dg-do link { target arm_soft_ok_link } } */ > /* { dg-skip-if "Feature is -mfloat-abi=soft only" { *-*-* } { "-mfloat-abi=*" } { "-mfloat-abi=soft" } } */ > /* { dg-options "-mfloat-abi=soft" } */ > > diff --git a/gcc/testsuite/gcc.target/arm/size-optimization-ieee-2.c b/gcc/testsuite/gcc.target/arm/size-optimization-ieee-2.c > index b4699271ceacc..e78a7ada62eb7 100644 > --- a/gcc/testsuite/gcc.target/arm/size-optimization-ieee-2.c > +++ b/gcc/testsuite/gcc.target/arm/size-optimization-ieee-2.c > @@ -1,4 +1,4 @@ > -/* { dg-do link { target arm_soft_ok } } */ > +/* { dg-do link { target arm_soft_ok_link } } */ > /* { dg-skip-if "Feature is -mfloat-abi=soft only" { *-*-* } { "-mfloat-abi=*" } { "-mfloat-abi=soft" } } */ > /* { dg-options "-mfloat-abi=soft" } */ > > diff --git a/gcc/testsuite/gcc.target/arm/size-optimization-ieee-3.c b/gcc/testsuite/gcc.target/arm/size-optimization-ieee-3.c > index 34b1ebe7afd60..bb9ccefda5e95 100644 > --- a/gcc/testsuite/gcc.target/arm/size-optimization-ieee-3.c > +++ b/gcc/testsuite/gcc.target/arm/size-optimization-ieee-3.c > @@ -1,4 +1,4 @@ > -/* { dg-do link { target arm_soft_ok } } */ > +/* { dg-do link { target arm_soft_ok_link } } */ > /* { dg-skip-if "Feature is -mfloat-abi=soft only" { *-*-* } { "-mfloat-abi=*" } { "-mfloat-abi=soft" } } */ > /* { dg-options "-mfloat-abi=soft" } */ > > diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp > index a1aef0e0a1622..ff8edbd3e1776 100644 > --- a/gcc/testsuite/lib/target-supports.exp > +++ b/gcc/testsuite/lib/target-supports.exp > @@ -3935,6 +3935,18 @@ proc check_effective_target_arm_soft_ok { } { > } "-mfloat-abi=soft"] > } > > +# Return 1 if this is an ARM target supporting -mfloat-abi=soft even > +# for linking. Some multilibs may be incompatible with this option, > +# and some linkers may reject incompatible options. > + > +proc check_effective_target_arm_soft_ok_link { } { > + return [check_no_compiler_messages arm_soft_ok_link executable { > + #include > + int dummy; > + int main (void) { return 0; } > + } "-mfloat-abi=soft"] > +} > + > # Return 1 if this is an ARM target supporting -mfpu=vfp with an > # appropriate abi.