Re: [ARM/FDPIC v5 04/21] [ARM] FDPIC: Add support for FDPIC for arm architecture

[Richard Sandiford <richard.sandiford@arm.com>]

Christophe Lyon <christophe.lyon@linaro.org> writes:
> +  if (SYMBOL_REF_P (orig))
> +    {
> +      if (CONSTANT_POOL_ADDRESS_P (orig))
> +	{
> +	  *is_readonly = true;
> +	  return true;
> +	}
> +      if (SYMBOL_REF_LOCAL_P (orig)
> +	  && !SYMBOL_REF_EXTERNAL_P (orig)
> +	  && SYMBOL_REF_DECL (orig)
> +	  && (!DECL_P (SYMBOL_REF_DECL (orig))
> +	      || !DECL_COMMON (SYMBOL_REF_DECL (orig))))
> +	{
> +	  tree decl = SYMBOL_REF_DECL (orig);
> +	  tree init = (TREE_CODE (decl) == VAR_DECL)
> +	    ? DECL_INITIAL (decl) : (TREE_CODE (decl) == CONSTRUCTOR)
> +	    ? decl : 0;
> +	  int reloc = 0;
> +	  bool named_section, readonly;
> +
> +	  if (init && init != error_mark_node)
> +	    reloc = compute_reloc_for_constant (init);
> +
> +	  named_section = TREE_CODE (decl) == VAR_DECL
> +	    && lookup_attribute ("section", DECL_ATTRIBUTES (decl));
> +	  readonly = decl_readonly_section (decl, reloc);
> +
> +	  /* We don't know where the link script will put a named
> +	     section, so return false in such a case.  */
> +	  if (named_section)
> +	    return false;
> +
> +	  *is_readonly = readonly;
> +	  return true;
> +	}
> +      else
> +	/* We don't know.  */
> +	return false;

Nit: no need for the "else".

OK with that changes, thanks.

Richard