From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-508353-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 20528 invoked by alias); 5 Sep 2019 08:03:20 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 20520 invoked by uid 89); 5 Sep 2019 08:03:20 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,SPF_PASS autolearn=no version=3.3.1 spammy=H*i:sk:CAKdteO
X-HELO: foss.arm.com
Received: from foss.arm.com (HELO foss.arm.com) (217.140.110.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Sep 2019 08:03:19 +0000
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 694FC28;	Thu,  5 Sep 2019 01:03:16 -0700 (PDT)
Received: from localhost (e121540-lin.manchester.arm.com [10.32.99.62])	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C91203F67D;	Thu,  5 Sep 2019 01:03:15 -0700 (PDT)
From: Richard Sandiford <richard.sandiford@arm.com>
To: Christophe Lyon <christophe.lyon@linaro.org>
Mail-Followup-To: Christophe Lyon <christophe.lyon@linaro.org>,Christophe Lyon <christophe.lyon@st.com>,  gcc Patches <gcc-patches@gcc.gnu.org>, richard.sandiford@arm.com
Cc: Christophe Lyon <christophe.lyon@st.com>,  gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [ARM/FDPIC v5 04/21] [ARM] FDPIC: Add support for FDPIC for arm architecture
References: <20190515124006.25840-1-christophe.lyon@st.com>	<20190515124006.25840-5-christophe.lyon@st.com>	<mptblxu8a41.fsf@arm.com>	<b6cf8cf9-def4-2438-6144-d4efd7fcd579@st.com>	<mptblw2he2t.fsf@arm.com>	<CAKdteOYLF-wDBxr4sCkyrbWaE=7VGjYujYxWNf9o4NcsTh2PGw@mail.gmail.com>	<mptpnkhg4de.fsf@arm.com>	<CAKdteOYfZX3guENyaMwXbmOvhegSUTZCJtEuvr4Njhciqnke1g@mail.gmail.com>
Date: Thu, 05 Sep 2019 08:03:00 -0000
In-Reply-To: <CAKdteOYfZX3guENyaMwXbmOvhegSUTZCJtEuvr4Njhciqnke1g@mail.gmail.com>	(Christophe Lyon's message of "Wed, 4 Sep 2019 21:58:57 +0200")
Message-ID: <mpty2z3cgql.fsf@arm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-IsSubscribed: yes
X-SW-Source: 2019-09/txt/msg00244.txt.bz2

Christophe Lyon <christophe.lyon@linaro.org> writes:
> +  if (SYMBOL_REF_P (orig))
> +    {
> +      if (CONSTANT_POOL_ADDRESS_P (orig))
> +	{
> +	  *is_readonly = true;
> +	  return true;
> +	}
> +      if (SYMBOL_REF_LOCAL_P (orig)
> +	  && !SYMBOL_REF_EXTERNAL_P (orig)
> +	  && SYMBOL_REF_DECL (orig)
> +	  && (!DECL_P (SYMBOL_REF_DECL (orig))
> +	      || !DECL_COMMON (SYMBOL_REF_DECL (orig))))
> +	{
> +	  tree decl = SYMBOL_REF_DECL (orig);
> +	  tree init = (TREE_CODE (decl) == VAR_DECL)
> +	    ? DECL_INITIAL (decl) : (TREE_CODE (decl) == CONSTRUCTOR)
> +	    ? decl : 0;
> +	  int reloc = 0;
> +	  bool named_section, readonly;
> +
> +	  if (init && init != error_mark_node)
> +	    reloc = compute_reloc_for_constant (init);
> +
> +	  named_section = TREE_CODE (decl) == VAR_DECL
> +	    && lookup_attribute ("section", DECL_ATTRIBUTES (decl));
> +	  readonly = decl_readonly_section (decl, reloc);
> +
> +	  /* We don't know where the link script will put a named
> +	     section, so return false in such a case.  */
> +	  if (named_section)
> +	    return false;
> +
> +	  *is_readonly = readonly;
> +	  return true;
> +	}
> +      else
> +	/* We don't know.  */
> +	return false;

Nit: no need for the "else".

OK with that changes, thanks.

Richard