From: Richard Sandiford <richard.sandiford@arm.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [committed] testsuite: Remove dg-options from pr100305.c [PR100305]
Date: Thu, 29 Apr 2021 10:58:12 +0100 [thread overview]
Message-ID: <mptzgxh9zuz.fsf@arm.com> (raw)
In-Reply-To: <20210429094742.GG1179226@tucnak> (Jakub Jelinek's message of "Thu, 29 Apr 2021 11:47:42 +0200")
Jakub Jelinek <jakub@redhat.com> writes:
> Hi!
>
> The test FAILs on i?86-linux (due to -Wpsabi warnings). But, on closer
> inspection it seems there is another problem, the dg-options in the testcase
> means that the test is compiled with -O0 -O, -O1 -O, -O2 -O, -O3 -O, -Os -O
> etc. options, so effectively is tested multiple times with the same options.
>
> Fixed by dropping the dg-options line, then we have -w by default and iterate
> over all the optimization levels (including the -O).
Gah, sorry about that. It started life as an aarch64-specific test,
where the dg-options was needed. I forgot to remove it when moving
the test.
Richard
> Tested on x86_64-linux with
> RUNTESTFLAGS='--target_board=unix\{-m32/-mno-sse,-m32,-m64\} compile.exp=pr100305.c'
> and committed to trunk and 11 as obvious.
>
> 2021-04-29 Jakub Jelinek <jakub@redhat.com>
>
> PR target/100305
> * gcc.c-torture/compile/pr100305.c: Remove dg-options. Add PR line.
>
> --- gcc/testsuite/gcc.c-torture/compile/pr100305.c.jj 2021-04-29 11:07:58.877205739 +0200
> +++ gcc/testsuite/gcc.c-torture/compile/pr100305.c 2021-04-29 11:39:42.161152369 +0200
> @@ -1,4 +1,4 @@
> -/* { dg-options "-O" } */
> +/* PR target/100305 */
>
> typedef double v2df __attribute__((vector_size(16)));
>
>
>
> Jakub
prev parent reply other threads:[~2021-04-29 9:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 16:56 [committed] aarch64: Fix address mode for vec_concat pattern [PR100305] Richard Sandiford
2021-04-29 9:47 ` [committed] testsuite: Remove dg-options from pr100305.c [PR100305] Jakub Jelinek
2021-04-29 9:58 ` Richard Sandiford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mptzgxh9zuz.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).