From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id B362D385DC2E for ; Wed, 26 Aug 2020 10:14:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B362D385DC2E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=richard.sandiford@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5D3771FB; Wed, 26 Aug 2020 03:14:18 -0700 (PDT) Received: from localhost (e121540-lin.manchester.arm.com [10.32.98.126]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C08093F66B; Wed, 26 Aug 2020 03:14:17 -0700 (PDT) From: Richard Sandiford To: xiezhiheng Mail-Followup-To: xiezhiheng , Richard Biener , "gcc-patches\@gcc.gnu.org" , richard.sandiford@arm.com Cc: Richard Biener , "gcc-patches\@gcc.gnu.org" Subject: Re: [PATCH PR94442] [AArch64] Redundant ldp/stp instructions emitted at -O3 References: <014c7f5ef7874db4ae98470c298b1f9b@huawei.com> <61bd22ee42114c6a823375a2b372decd@huawei.com> <6522d772e22a4453a6bd80026b3810d4@huawei.com> <3c4244b3625e4f7eb23f93c564ea687f@huawei.com> <4dc070cbaca04eb59d2cac94bed1a9c3@huawei.com> <8aa6988f8d27449b834d0793607f028f@huawei.com> <0ce8ec84dff744aeb3967cf8416e541d@huawei.com> <661e89c39af741f1927b3969f33721ac@huawei.com> Date: Wed, 26 Aug 2020 11:14:16 +0100 In-Reply-To: <661e89c39af741f1927b3969f33721ac@huawei.com> (xiezhiheng@huawei.com's message of "Wed, 26 Aug 2020 01:39:48 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_NUMSUBJECT, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2020 10:14:20 -0000 xiezhiheng writes: >> -----Original Message----- >> From: Richard Sandiford [mailto:richard.sandiford@arm.com] >> Sent: Tuesday, August 25, 2020 7:08 PM >> To: xiezhiheng >> Cc: Richard Biener ; gcc-patches@gcc.gnu.org >> Subject: Re: [PATCH PR94442] [AArch64] Redundant ldp/stp instructions >> emitted at -O3 >> >> xiezhiheng writes: >> >> -----Original Message----- >> >> From: Richard Sandiford [mailto:richard.sandiford@arm.com] >> >> Sent: Friday, August 21, 2020 5:02 PM >> >> To: xiezhiheng >> >> Cc: Richard Biener ; >> gcc-patches@gcc.gnu.org >> >> Subject: Re: [PATCH PR94442] [AArch64] Redundant ldp/stp instructions >> >> emitted at -O3 >> > >> > Cut... >> > >> >> Looks like the saturating intrinsics might need a bit more thought. >> >> Would you mind submitting the patch with just the other parts? >> >> Those were uncontroversial and it would be a shame to hold them >> >> up over this. >> > >> > Okay, I reorganized the existing patch and finished the first half of the >> intrinsics >> > except saturating intrinsics and load intrinsics. >> > >> > Bootstrapped and tested on aarch64 Linux platform. >> >> I know this'll be frustrating, sorry, but could you post the >> 2020-08-17 patch without the saturation changes? It's going to be >> easier to track and review if each patch deals with similar intrinsics. >> The non-saturating part of the 2020-08-17 patch was good because it was >> dealing purely with arithmetic operations. Loads should really be a >> separate change. >> >> BTW, for something like this, it's OK to test and submit several patches >> at once, so separating the patches doesn't need to mean longer test cycles. >> It's just that for review purposes, it's easier if one patch does one thing. >> > > That's true. And I finished the patch to add FLAG for add/sub arithmetic > intrinsics except saturating intrinsics. Later I will try to separate the rest > into several subsets to fix. > > Bootstrapped and tested on aarch64 Linux platform. Thanks, looks great. Pushed to master. Richard