From: Andreas Schwab <schwab@suse.de>
To: Andrew Pinski via Gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Andrew Pinski <apinski@marvell.com>
Subject: Re: [PATCH] Mark asm goto with outputs as volatile
Date: Tue, 27 Jun 2023 09:36:00 +0200 [thread overview]
Message-ID: <mvm1qhxxspr.fsf@suse.de> (raw)
In-Reply-To: <20230627032449.37404-1-apinski@marvell.com> (Andrew Pinski via Gcc-patches's message of "Mon, 26 Jun 2023 20:24:49 -0700")
On Jun 26 2023, Andrew Pinski via Gcc-patches wrote:
> diff --git a/gcc/gimplify.cc b/gcc/gimplify.cc
> index 0e24b915b8f..dc6a00e8bd9 100644
> --- a/gcc/gimplify.cc
> +++ b/gcc/gimplify.cc
> @@ -6935,7 +6935,12 @@ gimplify_asm_expr (tree *expr_p, gimple_seq *pre_p, gimple_seq *post_p)
> stmt = gimple_build_asm_vec (TREE_STRING_POINTER (ASM_STRING (expr)),
> inputs, outputs, clobbers, labels);
>
> - gimple_asm_set_volatile (stmt, ASM_VOLATILE_P (expr) || noutputs == 0);
> + /* asm is volatile if it was marked by the user as volatile or
> + there is no outputs or this is an asm goto. */
are
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
prev parent reply other threads:[~2023-06-27 7:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 3:24 Andrew Pinski
2023-06-27 7:13 ` Richard Biener
2023-06-27 17:23 ` Andrew Pinski
2023-06-28 16:20 ` Jeff Law
2023-06-27 7:36 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvm1qhxxspr.fsf@suse.de \
--to=schwab@suse.de \
--cc=apinski@marvell.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).