From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=OnQJ=CP=suse.de=schwab@sourceware.org>
Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c])
	by sourceware.org (Postfix) with ESMTPS id 51B053858D33
	for <gcc-patches@gcc.gnu.org>; Tue, 27 Jun 2023 07:36:01 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 51B053858D33
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
	by smtp-out1.suse.de (Postfix) with ESMTP id 880872189B;
	Tue, 27 Jun 2023 07:36:00 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1687851360; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=5x4dsaFGigiROBTBk13dvfNsqX6ypHjU9TaNOtJMCxE=;
	b=xvzRguTdVzqVpVV1+AuTZF0U6+MDetPFe6T4Fjnv2lUIUaE1gib0BgxkvZW8HoNvWgfEYY
	I80cxAjP+9wEe0AqpTHIZ9ENqgi7tBgYn1Vz7EvycmgJigoCAmueE4zMf7OrJLQXolAGK/
	b6nIVR5yhzw1ChDTE4rw+9hSaRNefXc=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1687851360;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=5x4dsaFGigiROBTBk13dvfNsqX6ypHjU9TaNOtJMCxE=;
	b=sef0yNN/ic4nGLicO0QOQwFeOqri0iLrdTIqzVU4Y2dyHH4IMT77kIE4zvdJYU01Gui2zM
	DzidPzrG3gkLr7AQ==
Received: from hawking.nue2.suse.org (unknown [10.168.4.11])
	by relay2.suse.de (Postfix) with ESMTP id 758132C141;
	Tue, 27 Jun 2023 07:36:00 +0000 (UTC)
Received: by hawking.nue2.suse.org (Postfix, from userid 17005)
	id 5EB934AAC98; Tue, 27 Jun 2023 09:36:00 +0200 (CEST)
From: Andreas Schwab <schwab@suse.de>
To: Andrew Pinski via Gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Andrew Pinski <apinski@marvell.com>
Subject: Re: [PATCH] Mark asm goto with outputs as volatile
In-Reply-To: <20230627032449.37404-1-apinski@marvell.com> (Andrew Pinski via
	Gcc-patches's message of "Mon, 26 Jun 2023 20:24:49 -0700")
References: <20230627032449.37404-1-apinski@marvell.com>
X-Yow: Of course, you UNDERSTAND about the PLAIDS in the SPIN CYCLE --
Date: Tue, 27 Jun 2023 09:36:00 +0200
Message-ID: <mvm1qhxxspr.fsf@suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Jun 26 2023, Andrew Pinski via Gcc-patches wrote:

> diff --git a/gcc/gimplify.cc b/gcc/gimplify.cc
> index 0e24b915b8f..dc6a00e8bd9 100644
> --- a/gcc/gimplify.cc
> +++ b/gcc/gimplify.cc
> @@ -6935,7 +6935,12 @@ gimplify_asm_expr (tree *expr_p, gimple_seq *pre_p, gimple_seq *post_p)
>        stmt = gimple_build_asm_vec (TREE_STRING_POINTER (ASM_STRING (expr)),
>  				   inputs, outputs, clobbers, labels);
>  
> -      gimple_asm_set_volatile (stmt, ASM_VOLATILE_P (expr) || noutputs == 0);
> +      /* asm is volatile if it was marked by the user as volatile or
> +	 there is no outputs or this is an asm goto.  */
               are

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."