From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44591 invoked by alias); 26 Jul 2017 14:33:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 42699 invoked by uid 89); 26 Jul 2017 14:33:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1085 X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Jul 2017 14:33:13 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9B4BAAC2F; Wed, 26 Jul 2017 14:33:10 +0000 (UTC) From: Andreas Schwab To: Torsten Duwe Cc: "Richard Earnshaw \(lists\)" , Sandra Loosemore , Maxim Kuvyrkov , Marek Polacek , Maxim Kuvyrkov , GCC Patches , Szabolcs Nagy , nd@arm.com, Li Bin , Jiri Kosina , Marcus Shawcroft , Takahiro Akashi , Andrew Wafaa Subject: Re: [PATCH v12] add -fpatchable-function-entry=N,M option References: <20170706140311.GA20710@suse.de> <20170707193028.GA17752@suse.de> <20170726142629.GG22969@suse.de> X-Yow: Here is my refrigerator full of FLANK STEAK...and over there is my UPHOLSTERED CANOE...I don't know WHY I OWN them!! Date: Wed, 26 Jul 2017 14:33:00 -0000 In-Reply-To: <20170726142629.GG22969@suse.de> (Torsten Duwe's message of "Wed, 26 Jul 2017 16:26:29 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2017-07/txt/msg01673.txt.bz2 On Jul 26 2017, Torsten Duwe wrote: > On Wed, Jul 26, 2017 at 04:16:25PM +0200, Andreas Schwab wrote: >> On Jul 07 2017, Torsten Duwe wrote: >> >> > diff --git a/gcc/testsuite/c-c++-common/patchable_function_entry-decl.c b/gcc/testsuite/c-c++-common/patchable_function_entry-decl.c >> > new file mode 100644 >> > index 00000000000..8514b10e820 >> > --- /dev/null >> > +++ b/gcc/testsuite/c-c++-common/patchable_function_entry-decl.c >> > @@ -0,0 +1,16 @@ >> > +/* { dg-do compile } */ >> > +/* { dg-options "-O2 -fpatchable-function-entry=3,1" } */ >> > +/* { dg-final { scan-assembler-times "nop" 2 } } */ >> >> This fails on ia64. > > The solution is fairly obvious: on architectures where the nop is not called > "nop" provide a custom, cpu-specific test, or document the failure. But on ia64, a nop _is_ called nop. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."